Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix default source_uri host #137151

Merged
merged 2 commits into from
Jul 26, 2022
Merged

[Fleet] Fix default source_uri host #137151

merged 2 commits into from
Jul 26, 2022

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Jul 26, 2022 •
edited
Loading

Summary

Part of #133828

Fixes default source_uri host as per @michalpristas comment:

the preconfigured URI on kibana side is incorrect it's https://artifacts.elastic.co/downloads/elastic-agent should be https://artifacts.elastic.co/downloads/ because it's common for all artifacts. artifact name such as elastic-agent or filebeat is computed.

Checklist

@criamico criamico added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jul 26, 2022
@criamico criamico requested a review from a team as a code owner July 26, 2022 08:10
@criamico criamico self-assigned this Jul 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

juliaElastic
juliaElastic approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@criamico criamico enabled auto-merge (squash) July 26, 2022 08:14
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #26 / machine learning - data visualizer data view management "before each" hook for "adds new field"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit d96fbc4 into elastic:main Jul 26, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

@michalpristas michalpristas michalpristas approved these changes

Assignees

@criamico criamico

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@criamico @elasticmachine @kibana-ci @michalpristas @juliaElastic @kibanamachine