[Maps] fix draw icons not displayed in buttons #138433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-gis (Team:Geo) |
nickpeihl
approved these changes
Aug 9, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Aug 9, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0f64304)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 9, 2022
…tic#138457) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0f64304) Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138402
elastic/eui#5967 migrated EuiIcon from css to emotion. This broke display of svg icons in maps because there where using the no longer available class "euiIcon". This PR upates these svg icons to instead spread props into svg to pass along emotion styling.
To test, follow directions at https://www.elastic.co/guide/en/kibana/current/import-geospatial-data.html#_draw_features_in_a_map and verify all icons are displayed in toolbar