[Lens] Metric trend PoC - toggle switch #138804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏳ Build in-progress, with failuresFailed CI StepsHistoryTo update your PR or re-run it, just comment with: |
drewdaemon
changed the title
|
Instead of For novice users, this setting could benefit from a tooltip. cc: @gchaps |
|
@KOTungseth thank you for the feedback! This is just a proof of concept so it will not be merged. I have linked to your suggestion from the official trend lines issue so we don't forget when we actually do this: #135882. Feel free to leave any other feedback on that issue or on the "real" PR in the future. |
|
Followed this strategy in #141851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a PoC for adding trendlines to the metric visualization in Lens. It is the toggle switch version of the UI.