Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Metric trend PoC - trendline layer #138811

Closed

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Aug 15, 2022

Summary

This is a PoC for adding trendlines to the metric visualization in Lens. It is the trendline layer version of the UI.

Testing instance

Screen Shot 2022-08-12 at 3 45 29 PM

@drewdaemon drewdaemon added skip-ci ci:cloud-deploy Create or update a Cloud deployment labels Aug 15, 2022
@tylersmalley
Copy link
Contributor

tylersmalley commented Aug 16, 2022

buildkite, test it

Removed skip-ci label so CI will run and deploy to cloud.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 16, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / ConfigPanel allow datasources and visualizations to use setters
  • [job] [logs] Jest Tests #2 / ConfigPanel initial default value should add an initial dimension value when clicking on the empty dimension button
  • [job] [logs] Jest Tests #2 / ConfigPanel initial default value should use group initial dimension value when adding a new layer if available
  • [job] [logs] Jest Tests #2 / Data Panel Wrapper Datasource data panel properties setState applies state immediately when option true
  • [job] [logs] Jest Tests #2 / Data Panel Wrapper Datasource data panel properties setState does not apply state immediately when option false
  • [job] [logs] Jest Tests #2 / IndexPattern Data Source #initializeDimension should add a new static value column if a static value is passed
  • [job] [logs] Jest Tests #2 / IndexPatternDimensionEditorPanel: onDrop dropping a dimension onDrop between layers references move_compatible; allows dropping to the compatible group in different layer to empty column
  • [job] [logs] Jest Tests #2 / IndexPatternDimensionEditorPanel: onDrop dropping a dimension onDrop between layers references replace_compatible: allows dropping to compatible group to replace an existing column
  • [job] [logs] Jest Tests #2 / IndexPatternDimensionEditorPanel: onDrop dropping a dimension onDrop between layers simple operations move_compatible; allows dropping to the compatible group in different layer to empty column
  • [job] [logs] Jest Tests #2 / IndexPatternDimensionEditorPanel: onDrop dropping a dimension onDrop between layers simple operations replace_compatible: allows dropping to compatible group to replace an existing column
  • [job] [logs] FTR Configs #30 / lens app - group 3 lens drag and drop tests dropping between layers should replace formula with another formula
  • [job] [logs] FTR Configs #30 / lens app - group 3 lens drag and drop tests dropping between layers should replace formula with another formula
  • [job] [logs] Jest Tests #2 / lensSlice state update should update the corresponding visualization state on update
  • [job] [logs] Jest Tests #2 / loader changeLayerIndexPattern handles errors
  • [job] [logs] Jest Tests #2 / loader changeLayerIndexPattern loads the index pattern and then changes the specified layer
  • [job] [logs] Jest Tests #2 / metric visualization dimension groups configuration generates configuration
  • [job] [logs] Jest Tests #2 / metric visualization generating an expression builds breakdown by metric
  • [job] [logs] Jest Tests #2 / metric visualization generating an expression builds single metric
  • [job] [logs] Jest Tests #2 / metric visualization getting supported layers works without state
  • [job] [logs] FTR Configs #43 / security APIs - PKI PKI authentication should reject API requests that use untrusted certificate
  • [job] [logs] FTR Configs #43 / security APIs - PKI PKI authentication should reject API requests that use untrusted certificate
  • [job] [logs] FTR Configs #17 / security APIs - User Profiles Getting user profiles in bulk "before all" hook for "can get multiple profiles"
  • [job] [logs] FTR Configs #17 / security APIs - User Profiles Getting user profiles in bulk "before all" hook for "can get multiple profiles"
  • [job] [logs] FTR Configs #10 / security app useremail login as new user and verify email
  • [job] [logs] FTR Configs #10 / security app useremail login as new user and verify email

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionMetricVis 60 61 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressionMetricVis 56 61 +5
lens 529 534 +5
total +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionMetricVis 71.3KB 71.4KB +90.0B
lens 1.2MB 1.2MB +7.6KB
total +7.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
expressionMetricVis 0 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionMetricVis 10.0KB 12.5KB +2.5KB
expressionXY 34.0KB 34.0KB +35.0B
lens 34.3KB 34.3KB +35.0B
total +2.6KB
Unknown metric groups

API count

id before after diff
expressionMetricVis 56 61 +5
lens 611 617 +6
total +11

ESLint disabled in files

id before after diff
apm 14 13 -1
observability 6 5 -1
total -2

ESLint disabled line counts

id before after diff
apm 81 78 -3
observability 44 43 -1
synthetics 57 51 -6
ux 10 9 -1
total -11

Total ESLint disabled count

id before after diff
apm 95 91 -4
observability 50 48 -2
synthetics 63 57 -6
ux 13 12 -1
total -13

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon closed this Sep 26, 2022
@drewdaemon drewdaemon deleted the metric-trend-poc-layer-strategy branch October 18, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cloud-deploy Create or update a Cloud deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants