Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Use index pattern service to load index patterns #138922

Closed
wants to merge 1 commit into from
Closed

[Canvas] Use index pattern service to load index patterns #138922

wants to merge 1 commit into from

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Aug 16, 2022 •
edited
Loading

@alexwizp alexwizp added Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.5.0 release_note:skip Skip the PR/issue when compiling release notes and removed v8.5.0 labels Aug 16, 2022
@alexwizp alexwizp self-assigned this Aug 16, 2022
@alexwizp alexwizp added v8.5.0 backport:skip This commit does not require backporting labels Aug 16, 2022
@alexwizp alexwizp requested a review from cqliu1 August 16, 2022 14:47
@alexwizp alexwizp marked this pull request as ready for review August 16, 2022 14:53
@alexwizp alexwizp requested a review from a team as a code owner August 16, 2022 14:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@alexwizp alexwizp added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Aug 16, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1149 1150 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB -37.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@cqliu1 cqliu1 mentioned this pull request Aug 29, 2022
Merged
9 tasks
@cqliu1
Copy link
Contributor

cqliu1 commented Aug 29, 2022

Closing in favor of #139610.

@cqliu1 cqliu1 closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqliu1 cqliu1 Awaiting requested review from cqliu1

Assignees

@alexwizp alexwizp

Labels
backport:skip This commit does not require backporting Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexwizp @elasticmachine @kibana-ci @cqliu1