Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Stats API #13896

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Sep 7, 2017

The /api/stats API needs to be removed for 6.0 and onward as this API is not yet ready enough to be consumed by 3rd parties. Rather than keep it around and suffer breaking changes mid-6.x, it will later be replaced with a new API in a plugin, and it will have a different structure for its data model.

Note that the server.getKibanaStats method is currently used, so it isn't yet being removed. This PR adds a note that mentions it will get a new home in the near future.

The original PR that added this was made by @stacey-gammon in #11992

@tsullivan tsullivan force-pushed the breaking/remove-stats-api branch from 7c288ff to 2ff59cf Compare September 12, 2017 19:47
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds fine to me.

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsullivan tsullivan merged commit a8171c2 into elastic:master Sep 12, 2017
@tsullivan tsullivan deleted the breaking/remove-stats-api branch September 12, 2017 20:47
tsullivan added a commit to tsullivan/kibana that referenced this pull request Sep 12, 2017
@tsullivan
Copy link
Member Author

6.x/6.1.0: 33aa0f4
6.0: #13969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants