Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. #141213

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Sep 21, 2022

Summary

Part of #137573.

Adds jest tests for query_utils/buildBaseFilterCriteria.

Checklist

@walterra walterra added :ml v8.5.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis labels Sep 21, 2022
@walterra walterra requested a review from a team as a code owner September 21, 2022 11:52
@walterra walterra self-assigned this Sep 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra added the release_note:skip Skip the PR/issue when compiling release notes label Sep 21, 2022
@walterra walterra mentioned this pull request Sep 21, 2022
19 tasks
@qn895
Copy link
Member

qn895 commented Sep 21, 2022

LGTM 🎉 Just had a few nit comments.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@walterra walterra merged commit dd2cfb7 into elastic:main Sep 22, 2022
@walterra walterra deleted the ml-aiops-jest-query-utils-1 branch September 22, 2022 13:55
@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 22, 2022
kibanamachine pushed a commit that referenced this pull request Sep 22, 2022
…seFilterCriteria. (#141213)

Adds jest tests for query_utils/buildBaseFilterCriteria.

(cherry picked from commit dd2cfb7)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2022
…seFilterCriteria. (elastic#141213)

Adds jest tests for query_utils/buildBaseFilterCriteria.

(cherry picked from commit dd2cfb7)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 22, 2022
…seFilterCriteria. (#141213) (#141438)

Adds jest tests for query_utils/buildBaseFilterCriteria.

(cherry picked from commit dd2cfb7)

Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 22, 2022
* main: (33 commits)
  Fix Next and Previous button on step screenshot carousel. (elastic#141422)
  [journeys] add a short delay after loading data (elastic#141437)
  skip failing test suite (elastic#140797)
  skip failing test suite (elastic#138776)
  Documents saved objects bulk delete API (elastic#141164)
  [Response Ops][Alerting] Defining default action params on connector type (elastic#141226)
  [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213)
  [APM] Fix search bar suggestions (elastic#141101)
  close popover on click (elastic#141272)
  [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276)
  [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239)
  [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228)
  [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288)
  Shameless copy of the retryTransientEsErrors from fleet (elastic#141246)
  [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735)
  Changing triggers actions ui routes to internal (elastic#141149)
  skip flaky test suit elastic#141356
  [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043)
  [dashboard controls] skip failing test on cloud (elastic#141291)
  [Synthetics] unskip edit_monitor api integration tests (elastic#141277)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants