Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Update the Notification indicator tooltip, add functional tests #141775

Merged
merged 11 commits into from
Sep 28, 2022
Merged

[ML] Update the Notification indicator tooltip, add functional tests #141775

merged 11 commits into from
Sep 28, 2022

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Sep 26, 2022 •
edited by kibanamachine
Loading

Summary

Part of #137573

  • Adds functional tests for the Notifications page and Notifications indicator
  • Adds API integration tests for the Notifications endpoints
  • Adds the last checked time to the Notifications indicator tooltip

Checklist

@darnautov darnautov self-assigned this Sep 26, 2022
@darnautov darnautov mentioned this pull request Sep 26, 2022
Closed
19 tasks
@darnautov darnautov added :ml test_ui_functional Team:ML Team label for ML (also use :ml) v8.5.0 v8.6.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 26, 2022
@darnautov darnautov marked this pull request as ready for review September 27, 2022 12:10
@darnautov darnautov requested a review from a team as a code owner September 27, 2022 12:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov
Copy link
Contributor Author

Checking with the flaky test runner

darnautov
darnautov commented Sep 27, 2022
View reviewed changes
x-pack/test/functional/services/ml/common_table_service.ts

export type MlTableService = ReturnType<typeof MlTableServiceProvider>;

export function MlTableServiceProvider({ getPageObject, getService }: FtrProviderContext) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to add a reusable service as we have many EUI tables and at the moment there is a lot of copy-pasted code.

peteharverson
peteharverson approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but otherwise tested and LGTM.

jgowdyelastic
jgowdyelastic approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov
Copy link
Contributor Author

Checking with the flaky test runner

pheyos
pheyos approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov enabled auto-merge (squash) September 28, 2022 09:33
@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 042c766 into elastic:main Sep 28, 2022
@kibanamachine kibanamachine mentioned this pull request Sep 28, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 28, 2022
@darnautov
[ML] Update the Notification indicator tooltip, add functional tests (e…
bf02989 
…lastic#141775)

(cherry picked from commit 042c766)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@darnautov darnautov deleted the ml-137573-notifications-tests branch September 28, 2022 10:42
kibanamachine added a commit that referenced this pull request Sep 28, 2022
@kibanamachine @darnautov
[ML] Update the Notification indicator tooltip, add functional tests (#…
b0b624d 
…141775) (#142066)

(cherry picked from commit 042c766)

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
@walterra walterra mentioned this pull request Oct 18, 2023
Merged
2 tasks
darnautov pushed a commit that referenced this pull request Oct 19, 2023
@walterra
[ML] Transform: Reenable/Fix cloning tests (#169072)
6a97a4b 
## Summary

Fixes #165883.

Reenables/fixes the cloning tests. Stabilises table assertions by
bringing the code in line with the assertions done in the `ml` plugin
(taken from here #141775).

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 19, 2023
@walterra
[ML] Transform: Reenable/Fix cloning tests (elastic#169072)
2c92028 
## Summary

Fixes elastic#165883.

Reenables/fixes the cloning tests. Stabilises table assertions by
bringing the code in line with the assertions done in the `ml` plugin
(taken from here elastic#141775).

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 6a97a4b)
kibanamachine added a commit that referenced this pull request Oct 19, 2023
@kibanamachine @walterra
[8.11] [ML] Transform: Reenable/Fix cloning tests (#169072) (#169372)
95ac33b 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[ML] Transform: Reenable/Fix cloning tests
(#169072)](#169072)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Walter
Rafelsberger","email":"walter.rafelsberger@elastic.co"},"sourceCommit":{"committedDate":"2023-10-19T11:45:18Z","message":"[ML]
Transform: Reenable/Fix cloning tests (#169072)\n\n##
Summary\r\n\r\nFixes #165883.\r\n\r\nReenables/fixes the cloning tests.
Stabilises table assertions by\r\nbringing the code in line with the
assertions done in the `ml` plugin\r\n(taken from here
#141775).\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6a97a4b6b866470620dfd37048b66162c886efd2","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:Transforms","v8.11.0","v8.12.0"],"number":169072,"url":"https://github.com/elastic/kibana/pull/169072","mergeCommit":{"message":"[ML]
Transform: Reenable/Fix cloning tests (#169072)\n\n##
Summary\r\n\r\nFixes #165883.\r\n\r\nReenables/fixes the cloning tests.
Stabilises table assertions by\r\nbringing the code in line with the
assertions done in the `ml` plugin\r\n(taken from here
#141775).\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6a97a4b6b866470620dfd37048b66162c886efd2"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169072","number":169072,"mergeCommit":{"message":"[ML]
Transform: Reenable/Fix cloning tests (#169072)\n\n##
Summary\r\n\r\nFixes #165883.\r\n\r\nReenables/fixes the cloning tests.
Stabilises table assertions by\r\nbringing the code in line with the
assertions done in the `ml` plugin\r\n(taken from here
#141775).\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6a97a4b6b866470620dfd37048b66162c886efd2"}}]}]
BACKPORT-->

Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

Assignees

@darnautov darnautov

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test_ui_functional test-api-integration v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@darnautov @elasticmachine @kibana-ci @kibanamachine @pheyos @peteharverson @jgowdyelastic