-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fix bug with fields.yml not defined, add jest tests for new transform installation mechanism in Fleet #142159
Conversation
Pinging @elastic/ml-ui (:ml) |
Pinging @elastic/fleet (Team:Fleet) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not the most familiar with that feature but tests looks good to me 🚀
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @qn895 |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these tests and the fix, looks good to me 🚀
Kyle is on leave this week so won't be able to review.
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…sform installation mechanism in Fleet (elastic#142159) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit a3e2af4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…sform installation mechanism in Fleet (elastic#142159) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…sform installation mechanism in Fleet (elastic#142159) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Follow up of #140046. This PR adds jest tests for the new transform installation mechanism in Fleet. It also fixes a bug with when
fields.yml
ormappings
are not defined.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers