[Enterprise Search] Fix index delete modal #142447
Conversation
| ? i18n.translate( | ||
| 'xpack.enterpriseSearch.content.searchIndices.deleteModal.closeButton.title', | ||
| { | ||
| defaultMessage: 'Close', | ||
| } | ||
| ) |
There was a problem hiding this comment.
Is this enough for translations?
There was a problem hiding this comment.
xpack.* seems to have no translation files (even an en.json) so is it possible we don't translate this?
There was a problem hiding this comment.
This is good enough for translations, there's no xpack-specific translation files, there's just giant translation files for everything in Kibana. English is the default message so that doesn't get a translation file.
navarone-feekery
added
auto-backport
navarone-feekery
changed the title
navarone-feekery
added
the
release_note:skip
|
@elasticmachine merge upstream |
| ? i18n.translate( | ||
| 'xpack.enterpriseSearch.content.searchIndices.deleteModal.closeButton.title', | ||
| { | ||
| defaultMessage: 'Close', | ||
| } | ||
| ) |
There was a problem hiding this comment.
This is good enough for translations, there's no xpack-specific translation files, there's just giant translation files for everything in Kibana. English is the default message so that doesn't get a translation file.
| @@ -72,8 +72,10 @@ export interface IndicesValues { | |||
| deleteModalIndex: ElasticsearchViewIndex | null; | |||
| deleteModalIndexName: string; | |||
| deleteModalIngestionMethod: IngestionMethod; | |||
| deleteStatus: typeof DeleteIndexApiLogic.values.status; | |||
There was a problem hiding this comment.
nitpick: this should just be typed as Status, which is already imported in this file.
There was a problem hiding this comment.
@sphilipse on L84 we also have status: typeof FetchIndicesAPILogic.values.status;. Should that also be changed to status: Status;?
There was a problem hiding this comment.
Probably yes! Not blocking either way.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* Disable index delete button during process * Change cancel to close during delete process (cherry picked from commit cc26353)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
* Disable index delete button during process * Change cancel to close during delete process
* Disable index delete button during process * Change cancel to close during delete process
Summary
https://github.com/elastic/enterprise-search-team/issues/2835
Deletebutton on index delete modal while process is runningCanceltext toCloseduring processChecklist
Delete any items that are not applicable to this PR.