Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds extra a11y tests for anomaly detection and DFA jobs #142589

Merged
merged 1 commit into from
Oct 5, 2022
Merged

[ML] Adds extra a11y tests for anomaly detection and DFA jobs #142589

merged 1 commit into from
Oct 5, 2022

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Oct 4, 2022 •
edited by kibanamachine
Loading

Adds extra accessibility tests for the anomaly detection and data frame analytics pages in the ML UI.

  • Multi-metric job wizard
  • Forecast modal in the Single Metric Viewer
  • Creating a regression job in the data frame analytics job wizard
  • Creating a classification job in the data frame analytics job wizard

Note the ml.ts file for ML accessibility tests is getting quite long and should be split up, but I plan on doing this as part of the test coverage work scheduled for 8.6.

Part of #137573
Part of #88496

@peteharverson peteharverson added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0 labels Oct 4, 2022
@peteharverson peteharverson self-assigned this Oct 4, 2022
@peteharverson peteharverson requested a review from a team as a code owner October 4, 2022 11:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

This was referenced Oct 4, 2022
Closed
Open
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #77899 failed 5b4b8f7602456aba652a6919873d381c65035258

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

jgowdyelastic
jgowdyelastic approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson merged commit 640592a into elastic:main Oct 5, 2022
@peteharverson peteharverson deleted the ml-add-a11y-tests branch October 5, 2022 09:47
@kibanamachine kibanamachine mentioned this pull request Oct 5, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2022
@peteharverson
[ML] Adds extra a11y tests for anomaly detection and DFA jobs (elasti…
1624c8a 
…c#142589)

(cherry picked from commit 640592a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 5, 2022
@kibanamachine @peteharverson
[ML] Adds extra a11y tests for anomaly detection and DFA jobs (#142589)…
1bb0d05 
… (#142710)

(cherry picked from commit 640592a)

Co-authored-by: Pete Harverson <pete@elastic.co>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@peteharverson @WafaaNasr
[ML] Adds extra a11y tests for anomaly detection and DFA jobs (elasti…
eb8a28f 
…c#142589)
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@peteharverson @WafaaNasr
[ML] Adds extra a11y tests for anomaly detection and DFA jobs (elasti…
c323b43 
…c#142589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@peteharverson peteharverson

Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peteharverson @elasticmachine @kibana-ci @kibanamachine @jgowdyelastic