-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves needs-team
auto labeling regex
#143787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves `needs-team` auto labeling regex Improvement: - fix full-text matching (using `^` and `$`) - Adds `EUI` as a team - Prevent empty `Team:` search See matching example between the old and new below... | Test label text | Old regex | New regex | |-----------------|-----------|-----------| | `Team:test` | ✅ | ✅ | | `Team:` | ✅ | ❌ | | `:ml` | ✅ | ✅ | | `:mlTeam:test` | ✅ (both) | ❌ | | `EUI` | ❌ | ✅ |
nickofthyme
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
ci:skip-when-possible
(Deprecated) no-op, managed automatically
labels
Oct 20, 2022
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - tested regex.
nickofthyme
changed the title
Update relabel.yml
Improves Oct 27, 2022
needs-team
auto labeling regex
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 27, 2022
* main: (24 commits) [Files] Add file upload to file picker (elastic#143969) [Security solution] Guided onboarding, alerts & cases (elastic#143598) [APM] Critical path for a single trace (elastic#143735) skip failing test suite (elastic#143933) [Fleet] Update GH Projects automation (elastic#144123) [APM] Performance fix for 'cardinality' telemetry task (elastic#144061) [Enterprise Search] Attach ML Inference Pipeline - Pipeline re-use (elastic#143979) [8.5][DOCS] Add support for differential logs (elastic#143242) Bump nwsapi from v2.2.0 to v2.2.2 (elastic#144001) [APM] Add waterfall to dependency operations (elastic#143257) [Shared UX] Add deprecation message to kibana react Markdown (elastic#143766) [Security Solution][Endpoint] Adds RBAC API checks for Blocklist (elastic#144047) Improve `needs-team` auto labeling regex (elastic#143787) [Reporting/CSV Export] _id field can not be formatted (elastic#143807) Adds SavedObjectsWarning to analytics results pages. (elastic#144109) Bump chromedriver to 107 (elastic#144073) Update cypress (elastic#143755) [Maps] nest security layers in layer group (elastic#144055) [Lens][Agg based Heatmap] Navigate to Lens Agg based Heatmap. (elastic#143820) Added support of saved search (elastic#144095) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
ci:skip-when-possible
(Deprecated) no-op, managed automatically
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v8.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves
needs-team
auto labeling regexImprovement:
^
and$
)EUI
as a teamTeam:
searchSee matching example between the old and new below...
Team:test
Team:
:ml
:mlTeam:test
EUI