Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Adds RBAC API checks for Blocklist #144047

Merged
merged 3 commits into from
Oct 27, 2022
Merged

[Security Solution][Endpoint] Adds RBAC API checks for Blocklist #144047

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46afd1c
Adds RBAC API checks for Blocklist
dasansol92 Oct 26, 2022
be3ce20
Merge branch 'main' into feat/olm-blocklists_RBAC_API-4924
dasansol92 Oct 27, 2022
0afc570
Change privilege to read for export method in all artifacts
dasansol92 Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions ...ins/security_solution/server/lists_integration/endpoint/validators/blocklist_validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,18 @@ export class BlocklistValidator extends BaseValidator {
return item.listId === ENDPOINT_BLOCKLISTS_LIST_ID;
}

protected async validateHasWritePrivilege(): Promise<void> {
return super.validateHasPrivilege('canWriteBlocklist');
}

protected async validateHasReadPrivilege(): Promise<void> {
return super.validateHasPrivilege('canReadBlocklist');
}

async validatePreCreateItem(
item: CreateExceptionListItemOptions
): Promise<CreateExceptionListItemOptions> {
await this.validateCanManageEndpointArtifacts();
await this.validateHasWritePrivilege();

item.entries = removeDuplicateEntryValues(item.entries as BlocklistConditionEntry[]);

Expand All @@ -228,27 +236,27 @@ export class BlocklistValidator extends BaseValidator {
}

async validatePreDeleteItem(): Promise<void> {
await this.validateCanManageEndpointArtifacts();
await this.validateHasWritePrivilege();
}

async validatePreGetOneItem(): Promise<void> {
await this.validateCanManageEndpointArtifacts();
await this.validateHasReadPrivilege();
}

async validatePreMultiListFind(): Promise<void> {
await this.validateCanManageEndpointArtifacts();
await this.validateHasReadPrivilege();
}

async validatePreExport(): Promise<void> {
await this.validateCanManageEndpointArtifacts();
await this.validateHasWritePrivilege();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be checking for read since its not doing any updates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a request from @caitlinbetz. We did the same for the other artifacts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. Ok. Its a bit strange - to be able to get/find, but I can't export.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I think I was confused previously. That makes sense to me. So those with read or all can export? I am good with that, apologies for the confusion!

}

async validatePreSingleListFind(): Promise<void> {
await this.validateCanManageEndpointArtifacts();
await this.validateHasReadPrivilege();
}

async validatePreGetListSummary(): Promise<void> {
await this.validateCanManageEndpointArtifacts();
await this.validateHasReadPrivilege();
}

async validatePreUpdateItem(
Expand All @@ -257,7 +265,7 @@ export class BlocklistValidator extends BaseValidator {
): Promise<UpdateExceptionListItemOptions> {
const updatedItem = _updatedItem as ExceptionItemLikeOptions;

await this.validateCanManageEndpointArtifacts();
await this.validateHasWritePrivilege();

_updatedItem.entries = removeDuplicateEntryValues(
_updatedItem.entries as BlocklistConditionEntry[]
Expand Down