[Discover] Improve warn feedback when data view has changed after rule creation #144392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explore-in-discover-for-adhoc-dw # Conflicts: # src/plugins/discover/public/application/main/discover_main_route.tsx
…explore-in-discover-for-adhoc-dw # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/utils.tsx
…hub.com/Dmitriynj/kibana into enable-alerts-for-adhoc-data-views
…alerts-for-adhoc-data-views # Conflicts: # src/plugins/discover/public/application/main/hooks/use_adhoc_data_views.ts # src/plugins/discover/public/application/main/hooks/use_discover_state.ts # test/functional/apps/discover/group2/_adhoc_data_views.ts # test/functional/page_objects/discover_page.ts
…import in discover, remove discover dependency in stack alerts, remove redundant contexts
…alerts-for-adhoc-data-views # Conflicts: # src/plugins/unified_search/public/dataview_picker/change_dataview.tsx
[Discover] Add types to es_query metadata
dimaanj
added
Feature:Discover
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @dimaanj |
|
Closing, since #144908 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #134232
This PR reduces cases
Data view changedtoast will appearance. For now, only