-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Presentation] Remove uses of export * from
in Presentation Util plugin
#145633
Changes from all commits
e281dd0
fdf2c13
81eab5d
841a527
9dacec9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,9 +6,6 @@ | |
* Side Public License, v 1. | ||
*/ | ||
|
||
// TODO: https://github.com/elastic/kibana/issues/110893 | ||
/* eslint-disable @kbn/eslint/no_export_all */ | ||
|
||
export const PLUGIN_ID = 'presentationUtil'; | ||
export const PLUGIN_NAME = 'presentationUtil'; | ||
|
||
|
@@ -18,4 +15,33 @@ export const PLUGIN_NAME = 'presentationUtil'; | |
*/ | ||
export const EXPRESSIONS_LANGUAGE_ID = 'kibana-expressions'; | ||
|
||
export * from './labs'; | ||
export type { | ||
EnvironmentName, | ||
EnvironmentStatus, | ||
Project, | ||
ProjectConfig, | ||
ProjectID, | ||
ProjectStatus, | ||
SolutionName, | ||
} from './labs'; | ||
|
||
export { | ||
LABS_PROJECT_PREFIX, | ||
environmentNames, | ||
projectIDs, | ||
projects, | ||
getProjectIDs, | ||
isProjectEnabledByStatus, | ||
} from './labs'; | ||
|
||
export { | ||
defaultTheme$, | ||
getElasticLogo, | ||
fontStyle, | ||
functionWrapper, | ||
getElasticOutline, | ||
isValidUrl, | ||
resolveWithMissingImage, | ||
encode, | ||
parseDataUrl, | ||
} from './lib'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm unsure about exporting these modules from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I personally like this approach a lot. I'm not sure why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!