Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Migrate share to locators #148850

Closed
wants to merge 2 commits into from

Conversation

kertal
Copy link
Member

@kertal kertal commented Jan 12, 2023

Summary

WIP, just to check

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kertal kertal added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Jan 12, 2023
@kertal kertal self-assigned this Jan 12, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 12, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Detections : Page Filters Alert list is updated when the alerts are updated
  • [job] [logs] Security Solution Tests #1 / Detections : Page Filters Alert list is updated when the alerts are updated
  • [job] [logs] FTR Configs #34 / discover app adhoc data views should update data view id when saving data view from hoc one
  • [job] [logs] FTR Configs #34 / discover app adhoc data views should update data view id when saving data view from hoc one
  • [job] [logs] FTR Configs #45 / discover Discover CSV Export Generate CSV: new search generates a report with single timefilter
  • [job] [logs] FTR Configs #45 / discover Discover CSV Export Generate CSV: new search generates a report with single timefilter
  • [job] [logs] FTR Configs #15 / discover/group1 shared links shared links with state in query permalink should allow for copying the saved object URL
  • [job] [logs] FTR Configs #15 / discover/group1 shared links shared links with state in query permalink should allow for copying the saved object URL
  • [job] [logs] FTR Configs #15 / discover/group1 shared links shared links with state in query permalink should allow for copying the snapshot URL
  • [job] [logs] FTR Configs #15 / discover/group1 shared links shared links with state in query permalink should allow for copying the snapshot URL
  • [job] [logs] FTR Configs #15 / discover/group1 shared links shared links with state in sessionStorage sharing hashed url shouldn't crash the app
  • [job] [logs] FTR Configs #15 / discover/group1 shared links shared links with state in sessionStorage sharing hashed url shouldn't crash the app
  • [job] [logs] FTR Configs #15 / discover/group1 shared links shared links with state in sessionStorage should allow for copying the snapshot URL as a short URL and should open it
  • [job] [logs] FTR Configs #15 / discover/group1 shared links shared links with state in sessionStorage should allow for copying the snapshot URL as a short URL and should open it

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 395.9KB 396.2KB +285.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal
Copy link
Member Author

kertal commented Jan 18, 2023

closing, POC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants