Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide all panel titles option at the dashboard level #15006

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Hide all panel titles option at the dashboard level #15006

merged 2 commits into from
Nov 21, 2017

Conversation

stacey-gammon
Copy link
Contributor

@stacey-gammon stacey-gammon commented Nov 16, 2017 •
edited
Loading

Add an option to hide all panel titles from a dashboard in view mode.

screen shot 2017-11-16 at 4 26 02 pm

screen shot 2017-11-16 at 4 26 16 pm

fixes #12563

@stacey-gammon stacey-gammon force-pushed the feature/hide-all-panel-titles branch from d3f4aad to 5aee68e Compare November 16, 2017 21:31
@kobelb
Copy link
Contributor

kobelb commented Nov 17, 2017

What's the motivation behind only hiding the title in view mode with this option? It does seem somewhat counter-intuitive that when you change that option it's not displayed immediately, but I'll refer to @elastic/kibana-design on that one :) Functionally, LGTM!

@stacey-gammon
Copy link
Contributor Author

Ah I did it to follow suit with how removing individual panel titles works, but now that I inspect closer, I'm doing it differently. In edit mode, we always show the panel header bar, but we still hide the title. I'll adjust so I'm really following suit, and this way you'll see something change so it won't be so weird.

screen shot 2017-11-17 at 3 31 40 pm

@stacey-gammon stacey-gammon force-pushed the feature/hide-all-panel-titles branch from 5aee68e to da43f38 Compare November 17, 2017 20:35
nreese
nreese approved these changes Nov 19, 2017
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stacey-gammon stacey-gammon force-pushed the feature/hide-all-panel-titles branch from da43f38 to 0922916 Compare November 20, 2017 15:21
@stacey-gammon stacey-gammon force-pushed the feature/hide-all-panel-titles branch from 0922916 to 8e2b303 Compare November 20, 2017 20:41
@stacey-gammon
Copy link
Contributor Author

stacey-gammon commented Nov 20, 2017 •
edited
Loading

Failing on a variation of #14920 - https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-selenium/8924/console ✖ fail: "visualize app tile map visualize app tile map chart should zoom in to level 10"

jenkins, test this

@stacey-gammon stacey-gammon merged commit 8bb0c87 into elastic:master Nov 21, 2017
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Nov 21, 2017
@stacey-gammon
Hide all panel titles option at the dashboard level (elastic#15006)
a9bc77f 
* Hide all panel titles option at the dashboard level

* Hide panel titles in edit mode too
@stacey-gammon stacey-gammon mentioned this pull request Nov 21, 2017
Merged
stacey-gammon added a commit that referenced this pull request Nov 21, 2017
@stacey-gammon
Hide all panel titles option at the dashboard level (#15006) (#15080)
a9ce9ee 
* Hide all panel titles option at the dashboard level

* Hide panel titles in edit mode too
@stacey-gammon stacey-gammon deleted the feature/hide-all-panel-titles branch November 21, 2017 17:53
This was referenced Nov 22, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@kobelb kobelb Awaiting requested review from kobelb

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features release_note:enhancement v6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard configuration: Show / hide panel titles
3 participants
@stacey-gammon @kobelb @nreese