Adding scope to all table headers, fix #12401 #15079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenins, test this |
|
Jenkins, test this |
cjcenizal
reviewed
Nov 21, 2017
| @@ -33,7 +33,7 @@ | |||
| <table ng-if="columns" class="table agg-table-group"> | |||
| <thead> | |||
| <tr> | |||
| <th ng-repeat="table in columns" ng-if="table.tables"> | |||
| <th ng-repeat="table in columns" ng-if="table.tables" scope="colgroup"> | |||
There was a problem hiding this comment.
What was your reasoning behind choosing colgroup in this file? The W3 page mentions this:
before making these associations [with scope="colgroup"], the structure of such groups of columns and rows needs to be defined in the table markup:
- A column group is defined using the element
My naive interpretation of this is that we shouldn't use scope="colgroup" unless there's a <colgroup> element.
There was a problem hiding this comment.
I would agree with you, that this is wrong here. Also looking at the HTML again, I think I just misread it, so will fix this.
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Nov 21, 2017
* Add scope for all th in Kibana * Add scope to <th> in ui framework * Update jest snapshots with scope * Fix wrong usage of colgroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
scopeattribute to allthelements where it makes sense. We still have a very few places left, we are using a table actually for styling purposes and not as a table, I haven't touched these places.It also adds the
scopeproperty for theKuiTableHeaderCellUI framework component.