[Security solutions] Fix execution context page #152816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
force-pushed
the
siem-explore-145276-fix-execution_context
branch
from
edf0d29 to
8447bf2
Compare
machadoum
changed the title
machadoum
added
Team:Threat Hunting
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
angorayc
approved these changes
Mar 8, 2023
afharo
approved these changes
Mar 9, 2023
x-pack/plugins/security_solution/public/common/hooks/use_update_execution_context.ts
Outdated
Show resolved
Hide resolved
machadoum
force-pushed
the
siem-explore-145276-fix-execution_context
branch
from
8447bf2 to
641346c
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @machadoum |
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
## Summary Event Based Telemetry sends context data for each event, for that it uses Kibana `ExecutionContext`. Before this PR events sent from Security Solutions had `context.page` value undefined. ### How to test it 1. Open the browser console and filter for EBT 2. Navigate between pages 3. Check if the click event has the right `context.page` value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Event Based Telemetry sends context data for each event, for that it uses Kibana
ExecutionContext. Before this PR events sent from Security Solutions hadcontext.pagevalue undefined.How to test it
context.pagevalue.