Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix the flaky useSecurityJobs test #153576

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[Security Solution] Fix the flaky useSecurityJobs test #153576

merged 1 commit into from
Mar 24, 2023

Conversation

xcrzx
Copy link
Contributor

@xcrzx xcrzx commented Mar 23, 2023 •
edited
Loading

Resolves: #153550

Summary

Fix the flaky useSecurityJobs test.

@xcrzx xcrzx added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Mar 23, 2023
@xcrzx xcrzx self-assigned this Mar 23, 2023
@xcrzx xcrzx changed the title [Security Solution] Fix a flaky test [Security Solution] Fix the flaky useSecurityJobs test Mar 24, 2023
@xcrzx xcrzx marked this pull request as ready for review March 24, 2023 09:37
@xcrzx xcrzx requested a review from a team as a code owner March 24, 2023 09:37
@xcrzx xcrzx requested a review from spong March 24, 2023 09:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@xcrzx xcrzx added release_note:skip Skip the PR/issue when compiling release notes v8.8.0 skipped-test labels Mar 24, 2023
spong
spong reviewed Mar 24, 2023
View reviewed changes
...lugins/security_solution/public/common/components/ml_popover/hooks/use_security_jobs.test.ts
Comment on lines +99 to +101
// addError might be called after an arbitrary number of renders, so we
// need to use waitFor here instead of waitForNextUpdate
await waitFor(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

  • 💔 Build #115269 failed 4a36ccde1d918e356f6c29ea9e4534e0621dfcfd
  • 💔 Build #115250 failed 4a36ccde1d918e356f6c29ea9e4534e0621dfcfd
  • 💛 Build #115108 was flaky 4a36ccde1d918e356f6c29ea9e4534e0621dfcfd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @xcrzx

@xcrzx xcrzx merged commit aa192f5 into elastic:main Mar 24, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 24, 2023
@xcrzx xcrzx deleted the flaky-fix branch March 24, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@xcrzx xcrzx

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes skipped-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.8.0
Projects
None yet
Milestone
No milestone
5 participants
@xcrzx @elasticmachine @kibana-ci @spong @kibanamachine