[Security Solution] Mapping cleanup for Signals Migration Saved Object #154949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields are captured in schema elsewhere (and validated there as well). This effort is part of @elastic/security-teamelastic#6268.
rylnd
added
technical debt
After deleting this field, test failures reminded me that we use this as a sortField when checking the migration status, so we need the field in some capacity. This previously worked despite the field being `index: false` because elasticsearch is able to sort on doc_values (https://www.elastic.co/guide/en/elasticsearch/reference/current/doc-values.html) However, in order to make this sorting more efficient, and because we'll never be able to remove `index: false` moving forward, I'm removing it here. This implicitly adds a mapping for this field.
💚 Build Succeeded
Metrics [docs]Saved Objects .kibana field count
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @rylnd |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
cc @rudolf |
rudolf
approved these changes
Apr 19, 2023
marshallmain
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These fields are captured in schema elsewhere (and validated there as well).
This effort is part of elastic/security-team#6268.