[Security Solution][Alerts] Format alerts for per-alert action context variables #155829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e40pud
added
the
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @e40pud |
kibanamachine
added
v8.8.0
backport:skip
e40pud
added a commit
to e40pud/kibana
that referenced
this pull request
Apr 27, 2023
…t variables (elastic#155829) ## Summary Closes [elastic#155812](elastic#155812) In elastic#155384, detection rules were switched to support per-alert actions. When passing the context variable, it was suggested that we should be calling formatAlert to format the alert for notifications, however doing that causes some test failures because formatAlert is fairly heavyweight and bunch of tests were timing out. Thanks to @marshallmain we have this much faster `expandDottedObject` that solves the issue with the very slow `formatAlert`. (cherry picked from commit 8f59720)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
e40pud
added a commit
that referenced
this pull request
Apr 27, 2023
…context variables (#155829) (#156009) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution][Alerts] Format alerts for per-alert action context variables (#155829)](#155829) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-04-26T16:16:41Z","message":"[Security Solution][Alerts] Format alerts for per-alert action context variables (#155829)\n\n## Summary\r\n\r\nCloses [#155812](https://github.com/elastic/kibana/issues/155812)\r\n\r\nIn #155384, detection rules were\r\nswitched to support per-alert actions. When passing the context\r\nvariable, it was suggested that we should be calling formatAlert to\r\nformat the alert for notifications, however doing that causes some test\r\nfailures because formatAlert is fairly heavyweight and bunch of tests\r\nwere timing out.\r\n\r\nThanks to @marshallmain we have this much faster `expandDottedObject`\r\nthat solves the issue with the very slow `formatAlert`.","sha":"8f597207a222f02b1c7664bc555a9f6e744bc4aa","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v8.8.0"],"number":155829,"url":"https://github.com/elastic/kibana/pull/155829","mergeCommit":{"message":"[Security Solution][Alerts] Format alerts for per-alert action context variables (#155829)\n\n## Summary\r\n\r\nCloses [#155812](https://github.com/elastic/kibana/issues/155812)\r\n\r\nIn #155384, detection rules were\r\nswitched to support per-alert actions. When passing the context\r\nvariable, it was suggested that we should be calling formatAlert to\r\nformat the alert for notifications, however doing that causes some test\r\nfailures because formatAlert is fairly heavyweight and bunch of tests\r\nwere timing out.\r\n\r\nThanks to @marshallmain we have this much faster `expandDottedObject`\r\nthat solves the issue with the very slow `formatAlert`.","sha":"8f597207a222f02b1c7664bc555a9f6e744bc4aa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155829","number":155829,"mergeCommit":{"message":"[Security Solution][Alerts] Format alerts for per-alert action context variables (#155829)\n\n## Summary\r\n\r\nCloses [#155812](https://github.com/elastic/kibana/issues/155812)\r\n\r\nIn #155384, detection rules were\r\nswitched to support per-alert actions. When passing the context\r\nvariable, it was suggested that we should be calling formatAlert to\r\nformat the alert for notifications, however doing that causes some test\r\nfailures because formatAlert is fairly heavyweight and bunch of tests\r\nwere timing out.\r\n\r\nThanks to @marshallmain we have this much faster `expandDottedObject`\r\nthat solves the issue with the very slow `formatAlert`.","sha":"8f597207a222f02b1c7664bc555a9f6e744bc4aa"}}]}] BACKPORT--> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #155812
In #155384, detection rules were switched to support per-alert actions. When passing the context variable, it was suggested that we should be calling formatAlert to format the alert for notifications, however doing that causes some test failures because formatAlert is fairly heavyweight and bunch of tests were timing out.
Thanks to @marshallmain we have this much faster
expandDottedObjectthat solves the issue with the very slowformatAlert.