[Security Solution] Maintenance Window callout: Update tests to match the test plan #156532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaindik
added
backport:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
nikitaindik
added
the
release_note:skip
jpdjere
approved these changes
May 3, 2023
nikitaindik
force-pushed
the
maintenance-window-callout-test-updates
branch
from
ffcee30
to
bcd290d
Compare
nikitaindik
changed the title
3 tasks
nikitaindik
force-pushed
the
maintenance-window-callout-test-updates
branch
from
bcd290d
to
ce7d396
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @nikitaindik |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
banderror
added
test
test-coverage
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nikitaindik
added a commit
to nikitaindik/kibana
that referenced
this pull request
May 4, 2023
… the test plan (elastic#156532) ## Summary This PR updates Maintenance Window callout tests to match the test plan. Maintenance Window callout is shown on the Rules Management page when there's a Maintenance Window running. <img width="1260" alt="233624339-9c9b6e3e-9e5e-424d-9d19-9cd7d4e92259" src="https://user-images.githubusercontent.com/15949146/235923634-53113720-d58a-4a15-b66b-b2008f80f035.png"> [**Test plan** (internal)](https://docs.google.com/document/d/1NTTbV7FemZR8LVwWBbDW3Jji58Wy2-n-YGycD698RR8/edit?usp=sharing ) [**Maintenance Window Callout issue**](elastic#155099) with more info about the feature (cherry picked from commit 508ab65)
nikitaindik
added a commit
that referenced
this pull request
May 4, 2023
… match the test plan (#156532) (#156727) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Maintenance Window callout: Update tests to match the test plan (#156532)](#156532) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2023-05-04T08:07:42Z","message":"[Security Solution] Maintenance Window callout: Update tests to match the test plan (#156532)\n\n## Summary\r\n\r\nThis PR updates Maintenance Window callout tests to match the test plan.\r\n\r\nMaintenance Window callout is shown on the Rules Management page when\r\nthere's a Maintenance Window running.\r\n\r\n<img width=\"1260\" alt=\"233624339-9c9b6e3e-9e5e-424d-9d19-9cd7d4e92259\"\r\nsrc=\"https://user-images.githubusercontent.com/15949146/235923634-53113720-d58a-4a15-b66b-b2008f80f035.png\">\r\n\r\n[**Test plan**\r\n(internal)](https://docs.google.com/document/d/1NTTbV7FemZR8LVwWBbDW3Jji58Wy2-n-YGycD698RR8/edit?usp=sharing\r\n)\r\n\r\n[**Maintenance Window Callout\r\nissue**](#155099) with more info\r\nabout the feature","sha":"508ab6521995eb044b16f6be15839d64de8c39e5","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","test-coverage","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rules","v8.8.0","v8.9.0"],"number":156532,"url":"https://github.com/elastic/kibana/pull/156532","mergeCommit":{"message":"[Security Solution] Maintenance Window callout: Update tests to match the test plan (#156532)\n\n## Summary\r\n\r\nThis PR updates Maintenance Window callout tests to match the test plan.\r\n\r\nMaintenance Window callout is shown on the Rules Management page when\r\nthere's a Maintenance Window running.\r\n\r\n<img width=\"1260\" alt=\"233624339-9c9b6e3e-9e5e-424d-9d19-9cd7d4e92259\"\r\nsrc=\"https://user-images.githubusercontent.com/15949146/235923634-53113720-d58a-4a15-b66b-b2008f80f035.png\">\r\n\r\n[**Test plan**\r\n(internal)](https://docs.google.com/document/d/1NTTbV7FemZR8LVwWBbDW3Jji58Wy2-n-YGycD698RR8/edit?usp=sharing\r\n)\r\n\r\n[**Maintenance Window Callout\r\nissue**](#155099) with more info\r\nabout the feature","sha":"508ab6521995eb044b16f6be15839d64de8c39e5"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156532","number":156532,"mergeCommit":{"message":"[Security Solution] Maintenance Window callout: Update tests to match the test plan (#156532)\n\n## Summary\r\n\r\nThis PR updates Maintenance Window callout tests to match the test plan.\r\n\r\nMaintenance Window callout is shown on the Rules Management page when\r\nthere's a Maintenance Window running.\r\n\r\n<img width=\"1260\" alt=\"233624339-9c9b6e3e-9e5e-424d-9d19-9cd7d4e92259\"\r\nsrc=\"https://user-images.githubusercontent.com/15949146/235923634-53113720-d58a-4a15-b66b-b2008f80f035.png\">\r\n\r\n[**Test plan**\r\n(internal)](https://docs.google.com/document/d/1NTTbV7FemZR8LVwWBbDW3Jji58Wy2-n-YGycD698RR8/edit?usp=sharing\r\n)\r\n\r\n[**Maintenance Window Callout\r\nissue**](#155099) with more info\r\nabout the feature","sha":"508ab6521995eb044b16f6be15839d64de8c39e5"}}]}] BACKPORT-->
![https://user-images.githubusercontent.com/15949146/235923634-53113720-d58a-4a15-b66b-b2008f80f035.png\">\r\n\r\n[**Test](https://user-images.githubusercontent.com/15949146/235923634-53113720-d58a-4a15-b66b-b2008f80f035.png\">\r\n\r\n[**Test){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Maintenance Window callout tests to match the test plan.
Maintenance Window callout is shown on the Rules Management page when there's a Maintenance Window running.
Test plan (internal)
Maintenance Window Callout issue with more info about the feature