Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] fix(index inference pipelines): fetch models on elser deploy #157318

Merged
merged 2 commits into from
May 11, 2023
Merged

[Enterprise Search] fix(index inference pipelines): fetch models on elser deploy #157318

merged 2 commits into from
May 11, 2023

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented May 10, 2023 •
edited by kibanamachine
Loading

Summary

Updated the inference pipeline flyout logic to refetch ml models when the user deploys the ELSER text expansion model. This will allow them to select the model if they deploy it from the flyout.

Screen.Recording.2023-05-10.at.1.46.15.PM.mov

@TattdCodeMonkey
fix(index inference pipelines): fetch models on elser deploy
aa457a3 
Updated the inference pipeline flyout logic to refetch ml models when
the user deploys the ELSER text expansion model. This will allow them to
select the model if they deploy it from the flyout.
@TattdCodeMonkey TattdCodeMonkey requested a review from a team May 10, 2023 18:46
@TattdCodeMonkey
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.4MB 2.4MB +119.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit efac422 into elastic:main May 11, 2023
@TattdCodeMonkey TattdCodeMonkey deleted the rnorris/fix/refetch-inference-models-on-elser-deploy branch May 11, 2023 13:53
demjened
demjened reviewed May 11, 2023
View reviewed changes
...terprise_search_content/components/search_index/pipelines/ml_inference/ml_inference_logic.ts
@@ -156,6 +160,7 @@ interface MLInferenceProcessorsActions {
setInferencePipelineConfiguration: (configuration: InferencePipelineConfiguration) => {
configuration: InferencePipelineConfiguration;
};
startTextExpansionModelSuccess: StartTextExpansionModelApiLogicActions['apiSuccess'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TattdCodeMonkey I believe the desired behavior is to update the list after the model download has begun (so after "create text expansion model"). A success response from that API indicates that the ELSER model placeholder has been created, so the user can start referencing it in a pipeline while the download is running.

@kibanamachine kibanamachine mentioned this pull request May 11, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 11, 2023
@TattdCodeMonkey
[Enterprise Search] fix(index inference pipelines): fetch models on e…
1da105b 
…lser deploy (elastic#157318)

## Summary

Updated the inference pipeline flyout logic to refetch ml models when
the user deploys the ELSER text expansion model. This will allow them to
select the model if they deploy it from the flyout.

https://github.com/elastic/kibana/assets/1972968/25916c61-cdad-4213-8034-265aaac1f945

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit efac422)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 11, 2023
@kibanamachine @TattdCodeMonkey
[8.8] [Enterprise Search] fix(index inference pipelines): fetch model…
299b39c 
…s on elser deploy (#157318) (#157393)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] fix(index inference pipelines): fetch models on
elser deploy (#157318)](#157318)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rodney
Norris","email":"rodney.norris@elastic.co"},"sourceCommit":{"committedDate":"2023-05-11T13:53:26Z","message":"[Enterprise
Search] fix(index inference pipelines): fetch models on elser deploy
(#157318)\n\n## Summary\r\n\r\nUpdated the inference pipeline flyout
logic to refetch ml models when\r\nthe user deploys the ELSER text
expansion model. This will allow them to\r\nselect the model if they
deploy it from the
flyout.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1972968/25916c61-cdad-4213-8034-265aaac1f945\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"efac422e192765c4db9dc0146c37c71ee4a5e653","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":157318,"url":"https://github.com/elastic/kibana/pull/157318","mergeCommit":{"message":"[Enterprise
Search] fix(index inference pipelines): fetch models on elser deploy
(#157318)\n\n## Summary\r\n\r\nUpdated the inference pipeline flyout
logic to refetch ml models when\r\nthe user deploys the ELSER text
expansion model. This will allow them to\r\nselect the model if they
deploy it from the
flyout.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1972968/25916c61-cdad-4213-8034-265aaac1f945\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"efac422e192765c4db9dc0146c37c71ee4a5e653"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157318","number":157318,"mergeCommit":{"message":"[Enterprise
Search] fix(index inference pipelines): fetch models on elser deploy
(#157318)\n\n## Summary\r\n\r\nUpdated the inference pipeline flyout
logic to refetch ml models when\r\nthe user deploys the ELSER text
expansion model. This will allow them to\r\nselect the model if they
deploy it from the
flyout.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1972968/25916c61-cdad-4213-8034-265aaac1f945\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"efac422e192765c4db9dc0146c37c71ee4a5e653"}}]}]
BACKPORT-->

Co-authored-by: Rodney Norris <rodney.norris@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demjened demjened demjened left review comments

@efegurkan efegurkan efegurkan approved these changes

Assignees
No one assigned
Labels
backport release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TattdCodeMonkey @kibana-ci @kibanamachine @efegurkan @demjened