[Discover] Rename internalState to sharedState #157830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ref HEAD~1..HEAD --fix'
kertal
added
Feature:Discover
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
commented
May 17, 2023
| useSelector: useDiscoverSharedStateSelector, | ||
| } = createStateContainerReactHelpers<ReduxLikeStateContainer<DiscoverSharedState>>(); | ||
|
|
||
| export function getSharedStateContainer() { |
There was a problem hiding this comment.
Github seems to think this is a new file, but just the file and functions and types were renamed
kertal
changed the title
jughosta
reviewed
May 22, 2023
| @@ -24,7 +24,7 @@ describe('buildStateSubscribe', () => { | |||
| appState: stateContainer.appState, | |||
| savedSearchState: stateContainer.savedSearchState, | |||
| dataState: stateContainer.dataState, | |||
| internalState: stateContainer.internalState, | |||
| internalState: stateContainer.sharedState, | |||
There was a problem hiding this comment.
Suggested change
| internalState: stateContainer.sharedState, | |
| sharedState: stateContainer.sharedState, |
Shouldn't it be updated too?
There was a problem hiding this comment.
definitely, well apply and align those suggestions 👍 thx
| @@ -36,7 +36,7 @@ export const buildStateSubscribe = | |||
| }: { | |||
| appState: DiscoverAppStateContainer; | |||
| dataState: DiscoverDataStateContainer; | |||
| internalState: DiscoverInternalStateContainer; | |||
| internalState: DiscoverSharedStateContainer; | |||
| @@ -26,7 +26,7 @@ export async function changeDataView( | |||
| appState, | |||
| }: { | |||
| services: DiscoverServices; | |||
| internalState: DiscoverInternalStateContainer; | |||
| internalState: DiscoverSharedStateContainer; | |||
| @@ -235,7 +225,7 @@ export function getDiscoverStateContainer({ | |||
| /** | |||
| * Internal State Container, state that's not persisted and not part of the URL | |||
| */ | |||
| const internalStateContainer = getInternalStateContainer(); | |||
| const internalStateContainer = getSharedStateContainer(); | |||
There was a problem hiding this comment.
Can we rename to sharedStateContainer for consistency?
| @@ -324,18 +314,6 @@ export function getDiscoverStateContainer({ | |||
| fetchData(); | |||
| }; | |||
|
|
|||
| const persistAdHocDataView = async (adHocDataView: DataView) => { | |||
There was a problem hiding this comment.
Where did we move this logic to?
There was a problem hiding this comment.
It's no longer necessary because of #154947
We needed to persist a temporary data view before sharing or creating CSVs , now it's possible without
There was a problem hiding this comment.
Makes sense. Thanks for explaining!
| @@ -26,7 +26,7 @@ import { DiscoverServices } from '../../../build_services'; | |||
| interface LoadSavedSearchDeps { | |||
| appStateContainer: DiscoverAppStateContainer; | |||
| dataStateContainer: DiscoverDataStateContainer; | |||
| internalStateContainer: DiscoverInternalStateContainer; | |||
| internalStateContainer: DiscoverSharedStateContainer; | |||
| @@ -180,7 +180,7 @@ export const loadAndResolveDataView = async ( | |||
| { | |||
| internalStateContainer, | |||
| services, | |||
| }: { internalStateContainer: DiscoverInternalStateContainer; services: DiscoverServices } | |||
| }: { internalStateContainer: DiscoverSharedStateContainer; services: DiscoverServices } | |||
|
Splitted out #158225 |
kertal
changed the title
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @kertal |
|
Closing since we discussed in the team, and considered this renaming as to be redundant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's renaming DiscoverInternalStateContainer (and dependencies) to DiscoverSharedStateContainer (it was mentioned by @mattkime that it's misleading, because internalState might indicate it's sort of private ... shared state is better naming IMO)
Checklist