-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Versioned and internal routes #159426
Conversation
1a61918
to
e684a98
Compare
Pinging @elastic/kibana-presentation (Team:Presentation) |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted route & versioned router onboarding LGTM, all as expected. Code review only, as it seems to me that if any saved object loading was off in Canvas, many tests would fail!
Summary
Closes #157101.
Closes #157083.
This refactors all Canvas routes to use the versioned router for BWC and makes access for all routes internal only. I also removed the
es_fields
routes because the last usage of that route was removed in #139610.All routes have been changed from
/api/canvas/*
to/internal/canvas/*
.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers