Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Fix save view infra test #160407

Merged
merged 1 commit into from
Jun 23, 2023
Merged

[Infra UI] Fix save view infra test #160407

merged 1 commit into from
Jun 23, 2023

Conversation

jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Jun 23, 2023 •
edited
Loading

Closes #157713

Summary

This PR fixes the failing test related to the saved views on the inventory page. I checked them locally and the clicks to open the drop down were missing so I added them.

@jennypavlova jennypavlova added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jun 23, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jennypavlova jennypavlova added the release_note:skip Skip the PR/issue when compiling release notes label Jun 23, 2023
@jennypavlova jennypavlova self-assigned this Jun 23, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 497 501 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

@jennypavlova jennypavlova marked this pull request as ready for review June 23, 2023 14:33
@jennypavlova jennypavlova requested a review from a team as a code owner June 23, 2023 14:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

mohamedhamed-ahmed
mohamedhamed-ahmed approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jennypavlova jennypavlova merged commit 2fa451c into elastic:main Jun 23, 2023
@jennypavlova jennypavlova deleted the 157713-inventory-fix-saved-view-test branch June 23, 2023 15:34
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jun 23, 2023
@jennypavlova jennypavlova mentioned this pull request Jun 26, 2023
Merged
jennypavlova added a commit that referenced this pull request Jun 27, 2023
@jennypavlova
Infra flaky test fixes (#160503)
7e7cf0f 
Closes #157711 and closes #157740
## Summary

This PR fixes the mentioned flaky tests together with the fix done in
#160407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedhamed-ahmed mohamedhamed-ahmed mohamedhamed-ahmed approved these changes

Assignees

@jennypavlova jennypavlova

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.10.0
Projects
None yet
Milestone
No milestone
6 participants
@jennypavlova @apmmachine @kibana-ci @elasticmachine @mohamedhamed-ahmed @kibanamachine