[Cases] Test `case_view_activity.test.tsx` suite #160639

cnasikas · 2023-06-27T14:45:20Z

Summary

Fixes flaky tests in x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx

Successful runs:

a7a19c1 (40 times)
f5e0645 (45 times)
d9838cc (40 times)

Fixes: #151981, #151979, #151980, #152209, #152207, #152208, #152203, #152203, #152201, #152206, #152202, #152204, #152200

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2023-06-29T13:21:52Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2023-06-29T13:21:54Z

Pinging @elastic/response-ops-cases (Feature:Cases)

cnasikas · 2023-06-29T14:26:26Z

@elasticmachine merge upstream

adcoelho · 2023-06-29T14:47:55Z

x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx

-    const result = appMockRender.render(<CaseViewActivity {...caseProps} />);
-    expect(result.queryByTestId('case-view-edit-connector')).toBeNull();
+    appMockRender.render(<CaseViewActivity {...caseProps} />);
+    expect(screen.queryByTestId('case-view-edit-connector')).toBeNull();


nit: to be consistent, maybe

Suggested change

expect(screen.queryByTestId('case-view-edit-connector')).toBeNull();

expect(screen.queryByTestId('case-view-edit-connector')).not.toBeInTheDocument();

?

Thanks. I will change it.

adcoelho · 2023-06-29T14:49:04Z

x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx

+    expect(await screen.findByTestId('case-tags')).toBeInTheDocument();
+    expect(await screen.findByTestId('cases-categories')).toBeInTheDocument();
+    expect(await screen.findByTestId('connector-edit-header')).toBeInTheDocument();
+    expect(await screen.findByTestId('case-view-status-action-button')).toBeInTheDocument();

    await waitForComponentToUpdate();


Here and in many others we have this at the end of the test, why?

If I remember correctly we had it to add to remove some warnings regarding the state getting updated after the end of the test. You can read more about it here https://kentcdodds.com/blog/fix-the-not-wrapped-in-act-warning

adcoelho · 2023-06-29T14:50:14Z

x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx

@@ -162,19 +168,21 @@ describe('Case View Page activity tab', () => {
  beforeEach(() => {
    jest.clearAllMocks();
    appMockRender = createAppMockRenderer();


not related but since we are here, this looks irrelevant no? Every test seems to re-initialize the appMockRenderer anyway

Yes, but I would like to keep it in the case in the future we add a test and do not re-initialize the appMockRenderer .

adcoelho

LGTM all changes are reasonable but reviewing I can't really tell if this fixes the flaky test definitely 😄

cnasikas · 2023-06-29T15:01:04Z

LGTM all changes are reasonable but reviewing I can't really tell if this fixes the flaky test definitely 😄

😄 The process I follow is the following:

I put a for-loop to run the test multiple times and create a PR.
I check the failed tests in the CI and try to fix them. Most of the time is about either timeouts or the test cannot find an item. await find* usually solves the issue. Removing unnecessary waitFor also helps.
I push again and see if there are any failures. Repeat until I do not see any failures in the CI
I run the tests 3 x (45-50) times and then I remove the for-loop and push again.

The Successful runs section in the description gives us pretty good confident that the test is not flaky anymore.

…case_activity_test

adcoelho · 2023-06-29T15:37:23Z

I put a for-loop to run the test multiple times and create a PR.

I check the failed tests in the CI and try to fix them. Most of the time is about either timeouts or the test cannot find an item. await find* usually solves the issue. Removing unnecessary waitFor also helps.

I push again and see if there are any failures. Repeat until I do not see any failures in the CI

I run the tests 3 x (45-50) times and then I remove the for-loop and push again.

Sounds good! I was just wondering if this time there was something else that might have escaped me 👍

kibana-ci · 2023-06-29T16:33:21Z

💚 Build Succeeded

Buildkite Build
Commit: 395d55b

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	14	16	+2
`securitySolution`	413	417	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	15	17	+2
`securitySolution`	492	496	+4
total			+6

History

💚 Build #139119 succeeded d9838cc
💚 Build #139082 succeeded f5e0645
💚 Build #139049 succeeded a7a19c1
💔 Build #139021 failed 1ec0e146e04bad84452709926c6494080562db4f
💔 Build #138999 failed d4c9a34
💔 Build #138970 failed 97bda6f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

## Summary Fixes flaky tests in `x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx` Successful runs: - elastic@a7a19c1 (40 times) - elastic@f5e0645 (45 times) - elastic@d9838cc (40 times) Fixes: elastic#151981, elastic#151979, elastic#151980, elastic#152209, elastic#152207, elastic#152208, elastic#152203, elastic#152203, elastic#152201, elastic#152206, elastic#152202, elastic#152204, elastic#152200 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6349724)

kibanamachine · 2023-06-29T16:41:08Z

💚 All backports created successfully

Status	Branch	Result
✅	8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…0930) # Backport This will backport the following commits from `main` to `8.9`: - [[Cases] Test `case_view_activity.test.tsx` suite (#160639)](#160639)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

Run test 50 times

3bbc8cf

cnasikas added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Jun 27, 2023

cnasikas self-assigned this Jun 27, 2023

cnasikas added 8 commits June 27, 2023 19:04

Run 45 times

30e44d5

Wait for elements to appear

5c8ce63

More fixes

b9ee535

Fix test

a656b12

Split long running tests

d422c4a

Run 40 times

97bda6f

Test without waitFor

d4c9a34

Make tests faster

a7a19c1

cnasikas force-pushed the case_activity_test branch from 1ec0e14 to a7a19c1 Compare June 29, 2023 09:44

Run 45 more times

f5e0645

cnasikas added v8.9.0 v8.10.0 labels Jun 29, 2023

cnasikas marked this pull request as ready for review June 29, 2023 13:21

cnasikas requested a review from a team as a code owner June 29, 2023 13:21

cnasikas added 2 commits June 29, 2023 16:22

Run 40 more times

d9838cc

Remove multiple runs

271fdd3

Merge branch 'main' into case_activity_test

7255285

adcoelho reviewed Jun 29, 2023

View reviewed changes

adcoelho approved these changes Jun 29, 2023

View reviewed changes

cnasikas enabled auto-merge (squash) June 29, 2023 15:01

cnasikas disabled auto-merge June 29, 2023 15:12

cnasikas added 2 commits June 29, 2023 18:12

Address feedback

dd7dd4f

Merge branch 'case_activity_test' of github.com:cnasikas/kibana into …

395d55b

…case_activity_test

cnasikas enabled auto-merge (squash) June 29, 2023 15:13

jonathan-buttner approved these changes Jun 29, 2023

View reviewed changes

cnasikas merged commit 6349724 into elastic:main Jun 29, 2023

cnasikas deleted the case_activity_test branch June 29, 2023 16:33

kibanamachine mentioned this pull request Jun 29, 2023

[8.9] [Cases] Test case_view_activity.test.tsx suite (#160639) #160930

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] Test `case_view_activity.test.tsx` suite #160639

[Cases] Test `case_view_activity.test.tsx` suite #160639

cnasikas commented Jun 27, 2023 •

edited by kibanamachine

Loading

elasticmachine commented Jun 29, 2023

elasticmachine commented Jun 29, 2023

cnasikas commented Jun 29, 2023

adcoelho Jun 29, 2023

cnasikas Jun 29, 2023

adcoelho Jun 29, 2023

cnasikas Jun 29, 2023

adcoelho Jun 29, 2023

cnasikas Jun 29, 2023

adcoelho left a comment

cnasikas commented Jun 29, 2023 •

edited

Loading

adcoelho commented Jun 29, 2023

kibana-ci commented Jun 29, 2023

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented Jun 29, 2023

	expect(screen.queryByTestId('case-view-edit-connector')).toBeNull();
	expect(screen.queryByTestId('case-view-edit-connector')).not.toBeInTheDocument();

[Cases] Test case_view_activity.test.tsx suite #160639

[Cases] Test case_view_activity.test.tsx suite #160639

Conversation

cnasikas commented Jun 27, 2023 • edited by kibanamachine Loading

Summary

Checklist

For maintainers

elasticmachine commented Jun 29, 2023

elasticmachine commented Jun 29, 2023

cnasikas commented Jun 29, 2023

adcoelho Jun 29, 2023

Choose a reason for hiding this comment

cnasikas Jun 29, 2023

Choose a reason for hiding this comment

adcoelho Jun 29, 2023

Choose a reason for hiding this comment

cnasikas Jun 29, 2023

Choose a reason for hiding this comment

adcoelho Jun 29, 2023

Choose a reason for hiding this comment

cnasikas Jun 29, 2023

Choose a reason for hiding this comment

adcoelho left a comment

Choose a reason for hiding this comment

cnasikas commented Jun 29, 2023 • edited Loading

adcoelho commented Jun 29, 2023

kibana-ci commented Jun 29, 2023

💚 Build Succeeded

Metrics [docs]

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented Jun 29, 2023

💚 All backports created successfully

Questions ?

[Cases] Test `case_view_activity.test.tsx` suite #160639

[Cases] Test `case_view_activity.test.tsx` suite #160639

cnasikas commented Jun 27, 2023 •

edited by kibanamachine

Loading

cnasikas commented Jun 29, 2023 •

edited

Loading