Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.9] [Security Solution] Fix Add Rules Page not refetching rules after package installed in background (#160389) #160892

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

…kage installed in background (elastic#160389)

Fixes elastic#160396

## Summary

- Invalidates cache after `security_detection_engine` package is
installed in the background so rules available for installation and for
upgrade are refetched, and their respective tables correctly populated
with them.
- Disable Install and Upgrade buttons in both tables while the package
is being installed in the background to prevent the user from attempting
to install/update outdated version.
- Add a Loading Skeleton in the Add Elastic Rules when the user
navigates to that page while the `security_detection_engine` is being
installed for the first time, to prevent the user from seeing a flash of
the "No available rules" component, before rules are loaded.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

(cherry picked from commit 2f03a25)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / Detection response view Open in timeline "after each" hook for "opens timeline with correct query count for open alerts by rule table"
  • [job] [logs] Security Solution Tests #3 / Detection response view Open in timeline opens timeline with correct query count for open alerts by rule table

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.0MB 11.0MB +600.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 415 419 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 496 500 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jpdjere

@kibanamachine kibanamachine merged commit 6871481 into elastic:8.9 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants