Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1601
Fixes #1561
Fixes a bug introduced by aca2457.
The code in aca2457 assumes that
SearchSources
would have anindexPattern
defined on them. This is the case withsavedSearches
but not for visualizations. Rather than use theindexPattern
saving build into theSavedObject
, they manage a separateindexPattern
property, and link it to theSearchSource
in theSavedObject#afterEsResp()
callback.This fixes the bug with the following updates:
SavedVis
no longer manages it's ownindexPattern
, it is managed by the underlyingSavedObject
searchSource.get('index')
will always work synchronouslyundefined
.rootSearchSource
does not update it's index pattern when the config is changedDataSource#getParent()
andDataSource#get()
behave synchronously.