Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] Remove extra data from tracking clicks #164378

Merged
merged 9 commits into from
Sep 14, 2023
Merged

[Security solution] Remove extra data from tracking clicks #164378

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ef70e82
wip
stephmilovic Aug 14, 2023
ed6c034
fix and test
stephmilovic Aug 14, 2023
1b5fbae
another property
stephmilovic Aug 14, 2023
fab13e0
Merge branch 'main' into rm_user_data_from_clicks
stephmilovic Aug 21, 2023
c88a555
add more html properties
stephmilovic Aug 21, 2023
8723160
Merge branch 'main' into rm_user_data_from_clicks
stephmilovic Sep 11, 2023
8cdd4a4
pr changes
stephmilovic Sep 11, 2023
838dade
revert url masking
stephmilovic Sep 13, 2023
7eeba80
Merge branch 'main' into rm_user_data_from_clicks
stephmilovic Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/core/analytics/core-analytics-browser-internal/src/track_clicks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,17 @@
import { fromEvent } from 'rxjs';
import type { AnalyticsClient } from '@kbn/analytics-client';

/** HTML attributes that should be skipped from reporting because they might contain user data */
const POTENTIAL_PII_HTML_ATTRIBUTES = ['value'];
/** HTML attributes that should be skipped from reporting because they might contain data we do not wish to collect */
const HTML_ATTRIBUTES_TO_REMOVE = [
'data-href',
'data-ech-series-name',
'data-provider-id',
'data-rfd-drag-handle-draggable-id',
'data-rfd-droppable-id',
'data-rfd-draggable-id',
'href',
'value',
];

/**
* Registers the event type "click" in the analytics client.
Expand Down Expand Up @@ -71,7 +80,7 @@ function getTargetDefinition(target: HTMLElement): string[] {
...(target.parentElement ? getTargetDefinition(target.parentElement) : []),
target.tagName,
...[...target.attributes]
.filter((attr) => !POTENTIAL_PII_HTML_ATTRIBUTES.includes(attr.name))
.filter((attr) => !HTML_ATTRIBUTES_TO_REMOVE.includes(attr.name))
.map((attr) => `${attr.name}=${attr.value}`),
];
}
Loading