Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] fix index template for serverless #165317

Merged
merged 8 commits into from
Sep 3, 2023
Merged

[Cloud Security] fix index template for serverless #165317

merged 8 commits into from
Sep 3, 2023

Conversation

CohenIdo
Copy link
Contributor

@CohenIdo CohenIdo commented Aug 31, 2023 •
edited
Loading

solves:

Delete ILM from index template in for serverless

@CohenIdo CohenIdo added ci:build-serverless-image backport:skip This commit does not require backporting labels Aug 31, 2023
@CohenIdo CohenIdo changed the title fix index template for serverless [Cloud Security] fix index template for serverless Aug 31, 2023
CohenIdo
CohenIdo commented Aug 31, 2023
View reviewed changes
...ns/security_solution_serverless/server/cloud_security/cloud_security_metering_task_config.ts Outdated
@@ -8,7 +8,7 @@
import { cloudSecurityMetringCallback } from './cloud_security_metering';
import type { MetringTaskProperties } from '../types';

const TASK_INTERVAL = 3600; // 1 hour
const TASK_INTERVAL = 120; // 1 hour
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for debugging only - will remove before merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CohenIdo Are you going to change the TASK_INTERVAL back to 3600?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep:)

@CohenIdo
Copy link
Contributor Author

@elasticmachine merge upstream

@CohenIdo CohenIdo marked this pull request as ready for review August 31, 2023 14:51
@CohenIdo CohenIdo requested review from a team as code owners August 31, 2023 14:51
@CohenIdo CohenIdo force-pushed the fix-cloud-security-index-template branch from 4f01717 to 3f4d4a6 Compare August 31, 2023 18:06
mitodrummer
mitodrummer approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@mitodrummer mitodrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CohenIdo
Copy link
Contributor Author

CohenIdo commented Sep 1, 2023

@elasticmachine merge upstream

@CohenIdo CohenIdo force-pushed the fix-cloud-security-index-template branch from ad53edb to a1d0177 Compare September 3, 2023 07:41
@CohenIdo CohenIdo enabled auto-merge (squash) September 3, 2023 08:04
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 3, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #11 / spaces api with security resolve copy to spaces conflicts superuser from the default space single-namespace types should return 200 when overwriting, with references

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5593 +5593
total size - 6.0MB +6.0MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CohenIdo CohenIdo merged commit aab1f8a into elastic:main Sep 3, 2023
@maxcold maxcold mentioned this pull request Sep 21, 2023
Merged
1 task
maxcold added a commit that referenced this pull request Sep 25, 2023
@maxcold
[Cloud Security] fix ingest pipeline for benchmark scores index (#166966
c7f49c2 
)

## Summary

during the [ILM fix](#165317) for
serverless the default pipeline for the scores index was also changed by
mistake. Reverting this change


### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
joemcelroy pushed a commit to joemcelroy/kibana that referenced this pull request Sep 25, 2023
@maxcold @joemcelroy
[Cloud Security] fix ingest pipeline for benchmark scores index (elas…
a84dcda 
…tic#166966)

## Summary

during the [ILM fix](elastic#165317) for
serverless the default pipeline for the scores index was also changed by
mistake. Reverting this change


### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalkraft eyalkraft eyalkraft approved these changes

@mitodrummer mitodrummer mitodrummer approved these changes

@Omolola-Akinleye Omolola-Akinleye Awaiting requested review from Omolola-Akinleye

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:build-serverless-image release_note:fix v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CohenIdo @kibana-ci @mitodrummer @Omolola-Akinleye @eyalkraft @kibanamachine