Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix ESQL flaky test #166249

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Sep 12, 2023
@jughosta jughosta self-assigned this Sep 12, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta marked this pull request as ready for review September 12, 2023 13:55
@jughosta jughosta requested a review from a team as a code owner September 12, 2023 13:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thx for taking care of this 🙏

@jughosta jughosta merged commit fd60453 into elastic:main Sep 18, 2023
7 checks passed
@jughosta jughosta deleted the 165860-flaky-esql-view-test branch September 18, 2023 07:35
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.10 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 166249

Questions ?

Please refer to the Backport tool documentation

@jughosta
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jughosta added a commit to jughosta/kibana that referenced this pull request Sep 18, 2023
- Closes elastic#165860

100x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3083

(cherry picked from commit fd60453)

# Conflicts:
#	test/functional/apps/discover/group2/_sql_view.ts
jughosta added a commit that referenced this pull request Sep 19, 2023
# Backport

This will backport the following commits from `main` to `8.10`:
- [[Discover] Fix ESQL flaky test
(#166249)](#166249)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-09-18T07:35:12Z","message":"[Discover]
Fix ESQL flaky test (#166249)\n\n- Closes
https://github.com/elastic/kibana/issues/165860\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3083","sha":"fd604538ca451b470f81f389838592dc8cf1f3ec","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.11.0"],"number":166249,"url":"https://github.com/elastic/kibana/pull/166249","mergeCommit":{"message":"[Discover]
Fix ESQL flaky test (#166249)\n\n- Closes
https://github.com/elastic/kibana/issues/165860\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3083","sha":"fd604538ca451b470f81f389838592dc8cf1f3ec"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166249","number":166249,"mergeCommit":{"message":"[Discover]
Fix ESQL flaky test (#166249)\n\n- Closes
https://github.com/elastic/kibana/issues/165860\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3083","sha":"fd604538ca451b470f81f389838592dc8cf1f3ec"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.10.2 v8.11.0
Projects
None yet
5 participants