-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] add api version to fleet call #166335
[Cloud Security] add api version to fleet call #166335
Conversation
@@ -21,6 +22,8 @@ export const useCisKubernetesIntegration = () => { | |||
const { http } = useKibana().services; | |||
|
|||
return useQuery<GetInfoResponse, DefaultPackagesInstallationError>(['integrations'], () => | |||
http.get<GetInfoResponse>(epmRouteService.getInfoPath(CLOUD_SECURITY_POSTURE_PACKAGE_NAME)) | |||
http.get<GetInfoResponse>(epmRouteService.getInfoPath(CLOUD_SECURITY_POSTURE_PACKAGE_NAME), { | |||
version: API_VERSIONS.public.v1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I don't understand why the e2e didn't fail when this was introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the check only enabled in local dev, therefore tests don't catch it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More detailed explanation in this discussion
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
Please add an automated test for this one/verify if we have a test how it passed and didn't fail ❤️ |
@kfirpeled we have a test that passing. I'm merging this PR but will investigate why the test didn't fail before closing the related ticket |
Summary
fixes
adding version to the fleet call