Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] add api version to fleet call #166335

Conversation

maxcold
Copy link
Contributor

@maxcold maxcold commented Sep 13, 2023

Summary

fixes

adding version to the fleet call

@maxcold maxcold added release_note:fix backport:skip This commit does not require backporting Team:Cloud Security Cloud Security team related labels Sep 13, 2023
@@ -21,6 +22,8 @@ export const useCisKubernetesIntegration = () => {
const { http } = useKibana().services;

return useQuery<GetInfoResponse, DefaultPackagesInstallationError>(['integrations'], () =>
http.get<GetInfoResponse>(epmRouteService.getInfoPath(CLOUD_SECURITY_POSTURE_PACKAGE_NAME))
http.get<GetInfoResponse>(epmRouteService.getInfoPath(CLOUD_SECURITY_POSTURE_PACKAGE_NAME), {
version: API_VERSIONS.public.v1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what I don't understand why the e2e didn't fail when this was introduced.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the check only enabled in local dev, therefore tests don't catch it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More detailed explanation in this discussion

@maxcold maxcold marked this pull request as ready for review September 13, 2023 10:44
@maxcold maxcold requested a review from a team as a code owner September 13, 2023 10:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 263.9KB 264.0KB +35.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kfirpeled
Copy link
Contributor

Please add an automated test for this one/verify if we have a test how it passed and didn't fail ❤️

@maxcold maxcold merged commit cfd65eb into main Sep 14, 2023
7 checks passed
@maxcold maxcold deleted the 7623-cloud-security-bug-navigation-to-integration-from-onboarding-components-doesnt-work branch September 14, 2023 13:28
@maxcold
Copy link
Contributor Author

maxcold commented Sep 14, 2023

@kfirpeled we have a test that passing. I'm merging this PR but will investigate why the test didn't fail before closing the related ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:Cloud Security Cloud Security team related v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants