Use push flyout for Discover document flyout #166406
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,12 +14,14 @@ import { | |
| EuiFlexItem, | ||
| EuiFlyout, | ||
| EuiFlyoutBody, | ||
| EuiFlyoutFooter, | ||
| EuiFlyoutHeader, | ||
| EuiTitle, | ||
| EuiSpacer, | ||
| EuiPortal, | ||
| EuiPagination, | ||
| keys, | ||
| EuiButtonEmpty, | ||
| } from '@elastic/eui'; | ||
| import type { Filter, Query, AggregateQuery } from '@kbn/es-query'; | ||
| import type { DataTableRecord } from '@kbn/discover-utils/types'; | ||
|
|
@@ -113,7 +115,9 @@ export function DiscoverGridFlyout({ | |
| <EuiPortal> | ||
| <EuiFlyout | ||
| onClose={onClose} | ||
| type="push" | ||
| size="m" | ||
| pushMinBreakpoint="xl" | ||
| data-test-subj="docTableDetailsFlyout" | ||
| onKeyDown={onKeyDown} | ||
| ownFocus={false} | ||
|
|
@@ -183,6 +187,15 @@ export function DiscoverGridFlyout({ | |
| textBasedHits={isPlainRecord ? hits : undefined} | ||
| /> | ||
| </EuiFlyoutBody> | ||
| <EuiFlyoutFooter> | ||
|
There was a problem hiding this comment. From the EUI docs (https://elastic.github.io/eui/#/layout/flyout#push-versus-overlay):
|
||
| <EuiFlexGroup> | ||
| <EuiFlexItem grow={false}> | ||
| <EuiButtonEmpty iconType="cross" onClick={onClose} flush="left"> | ||
| Close | ||
|
There was a problem hiding this comment. yes, this make sense, one ask, pls add i18n for |
||
| </EuiButtonEmpty> | ||
| </EuiFlexItem> | ||
| </EuiFlexGroup> | ||
| </EuiFlyoutFooter> | ||
| </EuiFlyout> | ||
| </EuiPortal> | ||
| ); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
ownFocusshould be true now, this would not apply for the push, but for the overlay style