[ES|QL] Do not allow saving in library action on text based panels #167111
Conversation
stratoula
added
release_note:skip
stratoula
added
the
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
| const { isOfAggregateQueryType } = await import('@kbn/es-query'); | ||
| const query = isFilterableEmbeddable(embeddable) && (await embeddable.getQuery()); | ||
| // Textbased panels (i.e. ES|QL, SQL) should not save to library | ||
| const isTextBasedEmbeddable = isOfAggregateQueryType(query as AggregateQuery); |
There was a problem hiding this comment.
Could you add a test to packages/kbn-es-query/src/es_query/es_aggregate_query.test.ts that verifies isOfAggregateQueryType returns false when query is undefined?
|
|
||
| const { isOfAggregateQueryType } = await import('@kbn/es-query'); | ||
| const query = isFilterableEmbeddable(embeddable) && (await embeddable.getQuery()); | ||
| // Textbased panels (i.e. ES|QL, SQL) should not save to library |
There was a problem hiding this comment.
Will this always be true? Why can't text based panels be saved to library? Would it be better to put an explicit flag on embeddable interface?
There was a problem hiding this comment.
This is a business decision we made for ES|QL. We don' t want them to be saved in library or being edited in Lens. The visualizations created with ESQL will always be by value ones.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Save to library action should not be present in ES|QL panels. For now we only allow by value embeddables and we don't want them to be edited/created in Lens editor
Checklist