Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] Improve AI connector error handling #167674

Merged
merged 12 commits into from
Oct 2, 2023

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Sep 29, 2023

Improves error handling on Generative AI connectors.

To test:

  1. Save this file as *.ndjson
  2. upload to saved objects page in Kibana
  3. open ai assistant
  4. use the connector selector to change between the new connectors and send a message to each one
  5. confirm you get a descriptive error for the connectors labeled bad
Screenshot 2023-10-02 at 4 20 38 PM

@stephmilovic stephmilovic added release_note:fix Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0 labels Sep 29, 2023
@stephmilovic stephmilovic requested review from a team as code owners September 29, 2023 16:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@@ -21,7 +21,7 @@ export function getConnectorType(): BedrockConnector {
id: BEDROCK_CONNECTOR_ID,
iconClass: lazy(() => import('./logo')),
selectMessage: i18n.translate('xpack.stackConnectors.components.bedrock.selectMessageText', {
defaultMessage: 'Send a request to AWS Bedrock systems.',
defaultMessage: 'Send a request to AWS Bedrock.',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit got lost for these couple of translations from the renaming PR, so I am tucking them in here. hope that is ok

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes lgtm

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #6 / Alert details expandable flyout right panel overview tab insights section should display threat intelligence section should display threat intelligence section
  • [job] [logs] Defend Workflows Cypress Tests #6 / Automated Response Actions From alerts "after all" hook for "should have generated endpoint and rule" "after all" hook for "should have generated endpoint and rule"
  • [job] [logs] Defend Workflows Cypress Tests #6 / Automated Response Actions From alerts "before all" hook for "should have generated endpoint and rule" "before all" hook for "should have generated endpoint and rule"
  • [job] [logs] FTR Configs #30 / core plugins rendering service exposes plugin config settings to authenticated users
  • [job] [logs] FTR Configs #69 / serverless observability UI Cases list "after all" hook in "Cases list"
  • [job] [logs] FTR Configs #69 / serverless observability UI Cases list empty state displays an empty list with an add button correctly
  • [job] [logs] FTR Configs #39 / serverless security UI Case View page "before all" hook for "should show the case view page correctly"
  • [job] [logs] FTR Configs #8 / Uptime app with real-world data overview page pagination is cleared when filter criteria changes

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4628 4634 +6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/elastic-assistant 74 75 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB +8.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackConnectors 37.8KB 37.8KB +11.0B
Unknown metric groups

API count

id before after diff
@kbn/elastic-assistant 94 95 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephmilovic stephmilovic merged commit 2174a95 into elastic:main Oct 2, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants