Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix missing item in output openapi specs #168938

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[Fleet] Fix missing item in output openapi specs #168938

merged 1 commit into from
Oct 16, 2023

Conversation

criamico
Copy link
Contributor

Fixes #167181

Summary

Fix of Fleet openapi specs: item was mistakenly removed in the responses of these two endpoints:

  • GET /outputs/{outputId}
  • PUT /outputs/{outputId}

Adding back the missing fields to align the actual behavior with the docs.

Checklist

  • Documentation was added for features that require explanation or tutorials

@criamico criamico self-assigned this Oct 16, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 16, 2023
@criamico criamico marked this pull request as ready for review October 16, 2023 09:46
@criamico criamico requested a review from a team as a code owner October 16, 2023 09:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico criamico requested a review from a team October 16, 2023 09:47
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

nchaulet
nchaulet approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

kilfoyle
kilfoyle approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@criamico criamico merged commit 5c42b9f into elastic:main Oct 16, 2023
7 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 16, 2023
@criamico criamico deleted the 167181 branch October 16, 2023 14:19
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
@criamico @dej611
[Fleet] Fix missing item in output openapi specs (elastic#168938)
d3a1241 
Fixes elastic#167181

## Summary
Fix of Fleet openapi specs: `item` was mistakenly removed in the
responses of these two endpoints:
- GET /outputs/{outputId}
- PUT /outputs/{outputId}

Adding back the missing fields to align the actual behavior with the
docs.

### Checklist

- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

@nchaulet nchaulet nchaulet approved these changes

Assignees

@criamico criamico

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Differences between Output API spec and what is returned by the API
7 participants
@criamico @apmmachine @elasticmachine @kibana-ci @nchaulet @kilfoyle @kibanamachine