-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Enable treemap in suggestions #169095
Conversation
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
@dej611 thank you! If you go to Discover, ES|QL mode and run a query like:
I expect to see treemap in the suggestions and I see it. The problem is that when I select I get an error and is never rendered It seems as the problem is on EC? Can you investigate and possibly create an issue? If treemap has performance issues in text based mode possibly we should not depict it there for now. |
You can also hit in dataview mode while the mosaic seems to render ok. 🤔 cc @nickofthyme |
I can reproduce the issue in Edit: the bug was already logged in our issue tracker here some time ago => #164730 |
@dej611 so we have already an issue! Nice. So I just wonder now, does it make sense to proceed with this PR? It is very easy to hit it especially on ES|QL mode |
I'll check the EC codebase and see whether a quick fix is viable there to unblock this and fix the logged issue |
/ci |
I think since #170914 got merged with the fix for treemap we could reconsider this PR again. |
@dej611 I still hit the bug 🤔 (I have bootstrapped) |
the fix will be in Kibana when #173329 will be merged |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
## Summary Enable treemaps in suggestions outside the partition chart realm. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Summary
Enable treemaps in suggestions outside the partition chart realm.
Checklist