Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Remove unnecessary ghost colors from EuiBottomBar #169308

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Oct 18, 2023

Summary

👋 Hey y'all - EUI will shortly be deprecating the ghost color in all button components (see https://eui.elastic.co/v89.0.0/#/navigation/button#ghost-vs-dark-mode).

In this PR, all components using color="ghost" are being used within an EuiBottomBar and as such already automatically inherit dark mode coloring.

I'm opening this PR ahead of time for your team so you can test this migration and ensure no UI regressions have occurred as a result.

Checklist

  • Tested in light and dark mode

- EuiBottomBar now sets a dark color mode on all children, so these colors are no longer necessary to specify
@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 EUI labels Oct 18, 2023
@cee-chen cee-chen marked this pull request as ready for review October 19, 2023 22:06
@cee-chen cee-chen requested a review from a team as a code owner October 19, 2023 22:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Cypress Tests #9 / Changing alert status Opening alerts can bulk open alerts can bulk open alerts
  • [job] [logs] Defend Workflows Cypress Tests #5 / Response console File operations: get-file, upload and execute "execute --command" - should execute a command "execute --command" - should execute a command
  • [job] [logs] Defend Workflows Cypress Tests #5 / Response console File operations: get-file, upload and execute "get-file --path" - should retrieve a file "get-file --path" - should retrieve a file
  • [job] [logs] Defend Workflows Cypress Tests #5 / Response console File operations: get-file, upload and execute "upload --file" - should upload a file "upload --file" - should upload a file
  • [job] [logs] Defend Workflows Cypress Tests #5 / Response console User journey for Processes operations: list, kill and suspend process "after all" hook for ""processes" - should obtain a list of processes" "after all" hook for ""processes" - should obtain a list of processes"
  • [job] [logs] Defend Workflows Cypress Tests #5 / Response console User journey for Processes operations: list, kill and suspend process "before all" hook for ""processes" - should obtain a list of processes" "before all" hook for ""processes" - should obtain a list of processes"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 572.2KB 572.2KB -1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cee-chen cee-chen merged commit 4df7a54 into elastic:main Oct 23, 2023
34 checks passed
@cee-chen cee-chen deleted the eui-ghost/security branch October 23, 2023 15:33
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants