Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build_dashboard serverless tests for MKI runs #171473

Merged
merged 4 commits into from
Nov 18, 2023
Merged

Fix build_dashboard serverless tests for MKI runs #171473

merged 4 commits into from
Nov 18, 2023

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Nov 17, 2023

Summary

This PR fixes the build_dashboard serverless ES3 tests for MKI runs by making sure there are no pre-existing data views.

Details

  • [Serverless Search] Create default data view when serverless_search plugin starts #170343 added a default data view, which made this test fail
    • the test expected no pre-existing data view, so the new default one broke things
    • the test didn't fail on CI as there were other tests running before that already cleaned up data views
    • this PR also added the { ignoreTimeFilter: true } parameter to a build_dashboard test, which wasn't needed
  • The test has been fixed by:
    • removing all pre-existing data views (and also cleaning up properly after the test)
    • removing the ignoreTimeFilter parameter from the createAndAddLensFromDashboard call

@pheyos pheyos added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.12.0 labels Nov 17, 2023
@pheyos pheyos self-assigned this Nov 17, 2023
@pheyos pheyos requested a review from a team as a code owner November 17, 2023 18:21
ThomThomson
ThomThomson approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes LGTM! Code only review.

@pheyos pheyos enabled auto-merge (squash) November 17, 2023 19:25
@pheyos
Copy link
Member Author

pheyos commented Nov 17, 2023

@elasticmachine merge upstream

@pheyos
Copy link
Member Author

pheyos commented Nov 18, 2023

@elasticmachine merge upstream

@pheyos
Copy link
Member Author

pheyos commented Nov 18, 2023

@elasticmachine merge upstream

@pheyos pheyos merged commit e04173d into elastic:main Nov 18, 2023
26 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

@pheyos pheyos deleted the fix_build_dashboard_test_for_mki branch November 18, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees

@pheyos pheyos

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pheyos @kibana-ci @ThomThomson @kibanamachine