Replace deprecated node-sass with sass #2 #173942

patrykkopycinski · 2023-12-23T00:30:55Z

Summary

The previous PR #161813 was reverted due to the broken webpack config
eef1afc

…ode-sass # Conflicts: # yarn.lock

…rkdown # Conflicts: # yarn.lock

…ode-sass # Conflicts: # package.json # yarn.lock

…-fix'

…ode-sass

mistic

lgtm

jbudz · 2023-12-26T13:56:55Z

buildkite test this

…/kibana into chore/replace-node-sass

…rkdown

patrykkopycinski · 2023-12-27T13:05:11Z

Thank you @jbudz for adding extra labels to test the config 🙇

kibana-ci · 2023-12-27T14:39:20Z

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

[job] [logs] Detection Engine - Security Solution Cypress Tests #4 / Timeline scope Modified badge Selecting new data view does not add a modified badge Selecting new data view does not add a modified badge

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1013.7KB	1013.7KB	-2.0B
`cloudSecurityPosture`	452.0KB	452.1KB	+12.0B
`controls`	199.7KB	199.7KB	-6.0B
`dashboard`	377.6KB	377.6KB	+4.0B
`dataViewManagement`	120.0KB	120.0KB	-2.0B
`dataVisualizer`	617.4KB	617.4KB	+10.0B
`discover`	592.4KB	592.4KB	+14.0B
`enterpriseSearch`	2.7MB	2.7MB	-52.0B
`eventAnnotationListing`	196.8KB	196.8KB	+16.0B
`filesManagement`	89.9KB	89.9KB	-4.0B
`graph`	387.3KB	387.3KB	+8.0B
`home`	137.4KB	137.4KB	-14.0B
`indexManagement`	585.2KB	585.2KB	+6.0B
`infra`	1.3MB	1.3MB	-4.0B
`ingestPipelines`	360.8KB	360.8KB	-4.0B
`kibanaOverview`	46.6KB	46.6KB	-4.0B
`kibanaReact`	214.5KB	214.7KB	+194.0B
`lens`	1.4MB	1.4MB	+4.0B
`logExplorer`	981.7KB	981.7KB	+10.0B
`management`	75.0KB	75.0KB	-4.0B
`maps`	2.9MB	2.9MB	+36.0B
`metricsDataAccess`	85.2KB	85.2KB	-4.0B
`ml`	3.6MB	3.6MB	+28.0B
`monitoring`	462.2KB	462.2KB	+66.0B
`observabilityShared`	36.3KB	36.3KB	-4.0B
`osquery`	1.0MB	1.0MB	-4.0B
`presentationUtil`	82.1KB	82.1KB	+10.0B
`security`	575.6KB	575.6KB	+16.0B
`securitySolution`	11.3MB	11.3MB	+2.0B
`securitySolutionEss`	46.4KB	46.4KB	-4.0B
`securitySolutionServerless`	361.2KB	361.2KB	-4.0B
`spaces`	174.9KB	174.9KB	-4.0B
`stackAlerts`	82.9KB	82.9KB	+10.0B
`unifiedDocViewer`	58.4KB	58.4KB	+6.0B
`unifiedSearch`	213.7KB	213.7KB	+8.0B
`visDefaultEditor`	141.0KB	140.9KB	-14.0B
`visTypeTimelion`	38.8KB	38.8KB	-4.0B
`visTypeVega`	1.8MB	1.8MB	-4.0B
`visTypeVislib`	339.7KB	339.7KB	+40.0B
`visualizations`	266.9KB	266.9KB	-28.0B
total			+330.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5722	+5722
`total size`	-	5.9MB	+5.9MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	377.9KB	378.0KB	+76.0B
`embeddable`	78.1KB	78.2KB	+20.0B
`esUiShared`	155.8KB	155.8KB	-4.0B
`globalSearchBar`	27.5KB	27.5KB	-6.0B
`kbnUiSharedDeps-npmDll`	6.2MB	6.2MB	+280.0B
`kibanaOverview`	15.2KB	15.1KB	-24.0B
`kibanaReact`	42.1KB	42.1KB	-6.0B
`osquery`	51.2KB	51.2KB	+10.0B
`searchprofiler`	18.7KB	18.8KB	+18.0B
total			+364.0B

History

💚 Build #185054 succeeded 093ec2e
💔 Build #185040 failed 5f6de30
💔 Build #185011 failed 2a5b394
💛 Build #184989 was flaky c2a364b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

jbudz · 2023-12-28T16:34:50Z

This already received approvals in #161813. I verified the updates address storybook compilation.

## Summary The previous PR elastic#161813 was reverted due to the broken webpack config elastic@eef1afc --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jon <jon@elastic.co> (cherry picked from commit d4be2a3)

kibanamachine · 2023-12-28T16:41:04Z

💔 Some backports could not be created

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts
✅	8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 173942

Questions ?

Please refer to the Backport tool documentation

jbudz · 2023-12-28T16:46:38Z

I closed the 8.12 backport, we just need 7.17 - targeting the same versions as the upgrade to Node 20.

kibanamachine · 2023-12-29T21:48:55Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 173942 locally

The previous PR elastic#161813 was reverted due to the broken webpack config elastic@eef1afc --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jon <jon@elastic.co>

kibanamachine · 2024-01-02T21:48:47Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

#173942 --------- Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com> Co-authored-by: Tiago Costa <tiago.costa@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

patrykkopycinski and others added 25 commits July 12, 2023 23:11

Replace deprecated node-sass with sass

8d42da3

fix

4757eff

fix

eb127d3

decrease timeout

69d3dfb

revert

9724bd9

timeout

3179c11

fix

e6bf726

timeout

0bd8025

Merge branch 'main' into chore/replace-node-sass

c918a67

sass-embedded

d2b44de

Merge branch 'main' of github.com:elastic/kibana into chore/replace-n…

c061e79

…ode-sass # Conflicts: # yarn.lock

Update casing_check_config.js

fcb95da

Update renovate.json

acd566a

add license

34e02fe

Merge branch 'main' of github.com:elastic/kibana into feat/mermaid-ma…

bce1d9a

…rkdown # Conflicts: # yarn.lock

test

33e3f7c

fix

17532ad

fix

4f1c6d1

fix

bd47e8b

Merge branch 'main' into chore/replace-node-sass

3fc60a6

Merge branch 'main' into chore/replace-node-sass

0f89f75

Merge branch 'main' of github.com:elastic/kibana into chore/replace-n…

ab38475

…ode-sass # Conflicts: # package.json # yarn.lock

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

df12625

…-fix'

fix sassOptions

eef1afc

Merge branch 'main' of github.com:elastic/kibana into chore/replace-n…

c2a364b

…ode-sass

patrykkopycinski self-assigned this Dec 23, 2023

patrykkopycinski requested review from a team as code owners December 23, 2023 00:30

patrykkopycinski mentioned this pull request Dec 23, 2023

Replace deprecated node-sass with sass #161813

Merged

patrykkopycinski added the release_note:skip Skip the PR/issue when compiling release notes label Dec 23, 2023

mistic approved these changes Dec 23, 2023

View reviewed changes

Merge branch 'main' into chore/replace-node-sass

2a5b394

jbudz added ci:build-canvas-shareable-runtime ci:cloud-deploy Create or update a Cloud deployment labels Dec 26, 2023

patrykkopycinski added 3 commits December 27, 2023 00:31

test

ebdf24a

Merge branch 'chore/replace-node-sass' of github.com:patrykkopycinski…

5f6de30

…/kibana into chore/replace-node-sass

Merge branch 'main' of github.com:elastic/kibana into feat/mermaid-ma…

093ec2e

…rkdown

update sass-loader

ffaae42

jbudz added the backport:all-open Backport to all branches that could still receive a release label Dec 28, 2023

jbudz merged commit d4be2a3 into elastic:main Dec 28, 2023
42 checks passed

kibanamachine added the v8.13.0 label Dec 28, 2023

kibanamachine mentioned this pull request Dec 28, 2023

[8.12] Replace deprecated node-sass with sass #2 (#173942) #174034

Closed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 29, 2023

jbudz mentioned this pull request Jan 2, 2024

[7.17] Replace deprecated node-sass with sass #174114

Merged

kibanamachine mentioned this pull request Jan 2, 2024

chore(NA): bump node into v20 #173461

Merged

kibanamachine mentioned this pull request Jan 2, 2024

Handle content stream errors in report pre-deletion #173792

Merged

1 task

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace deprecated node-sass with sass #2 #173942

Replace deprecated node-sass with sass #2 #173942

patrykkopycinski commented Dec 23, 2023 •

edited by kibanamachine

Loading

mistic left a comment

jbudz commented Dec 26, 2023

patrykkopycinski commented Dec 27, 2023

kibana-ci commented Dec 27, 2023 •

edited

Loading

jbudz commented Dec 28, 2023

kibanamachine commented Dec 28, 2023

jbudz commented Dec 28, 2023

kibanamachine commented Dec 29, 2023

kibanamachine commented Jan 2, 2024

Replace deprecated node-sass with sass #2 #173942

Replace deprecated node-sass with sass #2 #173942

Conversation

patrykkopycinski commented Dec 23, 2023 • edited by kibanamachine Loading

Summary

mistic left a comment

Choose a reason for hiding this comment

jbudz commented Dec 26, 2023

patrykkopycinski commented Dec 27, 2023

kibana-ci commented Dec 27, 2023 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Canvas Sharable Runtime

Page load bundle

History

jbudz commented Dec 28, 2023

kibanamachine commented Dec 28, 2023

💔 Some backports could not be created

Manual backport

Questions ?

jbudz commented Dec 28, 2023

kibanamachine commented Dec 29, 2023

kibanamachine commented Jan 2, 2024

patrykkopycinski commented Dec 23, 2023 •

edited by kibanamachine

Loading

kibana-ci commented Dec 27, 2023 •

edited

Loading