Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Make datastream rollover lazy #174790

Merged
merged 7 commits into from
Jan 15, 2024

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jan 12, 2024

Summary

Resolve #174480

Use the ?lazy parameter when triggering rollover from Fleet, this way rollover will only happen next time a doc is writtten.

Release note

Use the ?lazy parameter when triggering datastream rollover from Fleet, this way rollover will only happen next time a doc is writtten, this avoid overloading ES when updating a fleet package.

Tests

I updated the related automated tests and it seems to work as expected.

@nchaulet nchaulet self-assigned this Jan 12, 2024
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Jan 12, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet
Copy link
Member Author

/ci

@nchaulet nchaulet marked this pull request as ready for review January 15, 2024 13:59
@nchaulet nchaulet requested a review from a team as a code owner January 15, 2024 13:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wonder if we should document this in release notes, as it is changing a pretty basic functionality.

@nchaulet
Copy link
Member Author

LGTM, I wonder if we should document this in release notes, as it is changing a pretty basic functionality.

yes probably a good change to document 👍

@nchaulet nchaulet added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Jan 15, 2024
@nchaulet nchaulet enabled auto-merge (squash) January 15, 2024 15:13
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit b095635 into elastic:main Jan 15, 2024
21 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 15, 2024
@nchaulet nchaulet deleted the feature-fleet-lazy-rollover branch January 16, 2024 13:18
juliaElastic pushed a commit to juliaElastic/kibana that referenced this pull request Feb 9, 2024
juliaElastic added a commit that referenced this pull request Feb 9, 2024
## Summary

Add back changes in #174790 after
elastic/elasticsearch#104732 is fixed

Resolve #174480

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
## Summary

Add back changes in elastic#174790 after
elastic/elasticsearch#104732 is fixed

Resolve elastic#174480

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
## Summary

Add back changes in elastic#174790 after
elastic/elasticsearch#104732 is fixed

Resolve elastic#174480

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of lazy rollovers for invoked unconditional rollover
6 participants