-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Make datastream rollover lazy #174790
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I wonder if we should document this in release notes, as it is changing a pretty basic functionality.
yes probably a good change to document 👍 |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
## Summary Add back changes in #174790 after elastic/elasticsearch#104732 is fixed Resolve #174480 Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
## Summary Add back changes in elastic#174790 after elastic/elasticsearch#104732 is fixed Resolve elastic#174480 Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
## Summary Add back changes in elastic#174790 after elastic/elasticsearch#104732 is fixed Resolve elastic#174480 Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Summary
Resolve #174480
Use the
?lazy
parameter when triggering rollover from Fleet, this way rollover will only happen next time a doc is writtten.Release note
Use the
?lazy
parameter when triggering datastream rollover from Fleet, this way rollover will only happen next time a doc is writtten, this avoid overloading ES when updating a fleet package.Tests
I updated the related automated tests and it seems to work as expected.