[ES|QL] Reduce number of iterations on null columns #176174
Conversation
dej611
added
Feature:Discover
|
/ci |
|
/ci |
|
Seems fine but I want ci to run first |
|
/ci |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
| meta: { type: normalizeType(type) }, | ||
| isNull: true, | ||
| })) ?? []; | ||
| allColumns.sort((a, b) => Number(a.isNull) - Number(b.isNull)); |
There was a problem hiding this comment.
Why do we sort? I think in UI it's ordered by name anyway.
There was a problem hiding this comment.
Because with ?drop_null_columns you get only the values from non empty columns.
There was a problem hiding this comment.
Yes but what would not work without sorting on allColumns?
There was a problem hiding this comment.
No because you might have:
[{colA: null}, {colB: not null}, {colC: null}, {colD: not null}]
but on the values you get only
[1, 'a'] --> 1 is the value of col B and 'a' the value of colD
so if you don't put the null columns in the end then you are not having a correct match between your columns and values.
There was a problem hiding this comment.
Got it. Do we have a test to make sure that values are read correctly according to columns?
There was a problem hiding this comment.
Yes I added one in my PR (the one we merged)
Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com>
|
/ci |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
## Summary Follow up on elastic#174585 Less code, less iterations. --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com>
## Summary Follow up on elastic#174585 Less code, less iterations. --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com>
## Summary Follow up on elastic#174585 Less code, less iterations. --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com>
Summary
Follow up on #174585
Less code, less iterations.