Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove angular from AggConfig #17668

Merged
merged 3 commits into from
Apr 17, 2018
Merged

remove angular from AggConfig #17668

merged 3 commits into from
Apr 17, 2018

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Apr 12, 2018 •
edited
Loading

remove angular from AggConfig

@ppisljar ppisljar added WIP Work in progress Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Apr 12, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ppisljar ppisljar force-pushed the ang/removeAngularAggConfig branch from e94f70e to eef9e9f Compare April 12, 2018 12:32
@ppisljar ppisljar changed the title WIP remove angular from AggConfig remove angular from AggConfig Apr 12, 2018
@ppisljar ppisljar added review chore v7.0.0 v6.3.0 and removed WIP Work in progress labels Apr 12, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ppisljar ppisljar force-pushed the ang/removeAngularAggConfig branch from eef9e9f to c29c1cc Compare April 12, 2018 14:36
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

timroes
timroes approved these changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some leftover commented tests in src/ui/public/vis/__tests__/_agg_configs.js and some configurable: true left over. Besides that LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar
Copy link
Member Author

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar
Copy link
Member Author

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor

timroes commented Apr 17, 2018

You need to rebase this on master to get rid of the failing tests.

@ppisljar ppisljar force-pushed the ang/removeAngularAggConfig branch from 2a1ecfd to 0d69e5b Compare April 17, 2018 11:13
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ppisljar ppisljar merged commit a87e862 into elastic:master Apr 17, 2018
ppisljar added a commit to ppisljar/kibana that referenced this pull request Apr 18, 2018
@ppisljar
remove angular from AggConfig (elastic#17668)
fc09a0d
@ppisljar ppisljar mentioned this pull request Apr 18, 2018
Merged
@ppisljar ppisljar added v6.3.0 and removed backport labels Apr 18, 2018
ppisljar added a commit that referenced this pull request Apr 18, 2018
@ppisljar
remove angular from AggConfig (#17668) (#17765)
2045c93
@timroes timroes mentioned this pull request Dec 12, 2018
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v6.3.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppisljar @elasticmachine @timroes @thomasneirynck