Upgrade EUI to v93.2.0 #177361
Merged
Upgrade EUI to v93.2.0 #177361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
release_note:skip
cee-chen
force-pushed
the
eui/v93.2.0
branch
3 times, most recently
from
5036294 to
8fe805c
Compare
- for the medium breakpoint/collapsed EuiFlyout usage, this requires nesting an `EuiPageSidebar` in the flyout - also requires some extra Security CSS selector tweaks
cee-chen
force-pushed
the
eui/v93.2.0
branch
from
8fe805c to
6d55aa3
Compare
|
/ci |
|
Pinging @elastic/eui-team (EUI) |
Ikuni17
approved these changes
Feb 21, 2024
ryankeairns
approved these changes
Feb 21, 2024
pgayvallet
approved these changes
Feb 22, 2024
tsullivan
approved these changes
Feb 23, 2024
|
@elastic/security-solution Going to skip approval from your team and request for an admin merge by EOD. Side nav changes have been QA'd by someone from the design team and Shared UX team and should not contain any UI regressions pertaining your solution. If you find that to not be the case post-merge, please feel free to ping our team any time! |
rylnd
approved these changes
Feb 23, 2024
|
Thanks @rylnd, you rock! A quick click-through is perfect - basically if your solution side nav doesn't look wonky, everything should be shipshape! |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
The failing tests are both known to be flaky. Merging now. |
semd
pushed a commit
to semd/kibana
that referenced
this pull request
Mar 4, 2024
`v93.1.1`⏩ `v93.2.0` --- - Updated `EuiPageSidebar` and `EuiPageTemplate.Sidebar` with a new `hasEmbellish` prop (defaults to false) ([elastic#7521](elastic/eui#7521)) - Added `diff` glyph to `EuiIcon` ([elastic#7520](elastic/eui#7520)) - Added `newChat` glyph to `EuiIcon` ([elastic#7524](elastic/eui#7524)) **Bug fixes** - Fixed `EuiSideNav` not correctly typing the `items` prop as required ([elastic#7521](elastic/eui#7521)) - Fixed the `CSS is not defined` bug in `EuiPageTemplate` when rendering in some SSR environments, particularly Next.js v13 and up ([elastic#7525](elastic/eui#7525)) - Fixed `EuiDataGrid` component to clean up timer from side effect on unmount ([elastic#7534](elastic/eui#7534)) **Accessibility** - Fixed `EuiSideNav` to render a fallback aria-label on mobile toggles if no heading or mobile title exists ([elastic#7521](elastic/eui#7521)) **CSS-in-JS conversions** - Converted `EuiSideNav` to Emotion; Removed the following Sass variables: ([elastic#7521](elastic/eui#7521)) - `$euiSideNavEmphasizedBackgroundColor` - `$euiSideNavRootTextcolor` - `$euiSideNavBranchTextcolor` - `$euiSideNavSelectedTextcolor` - `$euiSideNavDisabledTextcolor` - Removed the `euiSideNavEmbellish` Sass mixin. Use the new `EuiPageSidebar` `hasEmbellish` prop instead ([elastic#7521](elastic/eui#7521)) - Added a new memoization/performance optimization utility for CSS-in-JS styles ([elastic#7529](elastic/eui#7529))
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
`v93.1.1`⏩ `v93.2.0` --- - Updated `EuiPageSidebar` and `EuiPageTemplate.Sidebar` with a new `hasEmbellish` prop (defaults to false) ([elastic#7521](elastic/eui#7521)) - Added `diff` glyph to `EuiIcon` ([elastic#7520](elastic/eui#7520)) - Added `newChat` glyph to `EuiIcon` ([elastic#7524](elastic/eui#7524)) **Bug fixes** - Fixed `EuiSideNav` not correctly typing the `items` prop as required ([elastic#7521](elastic/eui#7521)) - Fixed the `CSS is not defined` bug in `EuiPageTemplate` when rendering in some SSR environments, particularly Next.js v13 and up ([elastic#7525](elastic/eui#7525)) - Fixed `EuiDataGrid` component to clean up timer from side effect on unmount ([elastic#7534](elastic/eui#7534)) **Accessibility** - Fixed `EuiSideNav` to render a fallback aria-label on mobile toggles if no heading or mobile title exists ([elastic#7521](elastic/eui#7521)) **CSS-in-JS conversions** - Converted `EuiSideNav` to Emotion; Removed the following Sass variables: ([elastic#7521](elastic/eui#7521)) - `$euiSideNavEmphasizedBackgroundColor` - `$euiSideNavRootTextcolor` - `$euiSideNavBranchTextcolor` - `$euiSideNavSelectedTextcolor` - `$euiSideNavDisabledTextcolor` - Removed the `euiSideNavEmbellish` Sass mixin. Use the new `EuiPageSidebar` `hasEmbellish` prop instead ([elastic#7521](elastic/eui#7521)) - Added a new memoization/performance optimization utility for CSS-in-JS styles ([elastic#7529](elastic/eui#7529))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v93.1.1⏩v93.2.0EuiPageSidebarandEuiPageTemplate.Sidebarwith a newhasEmbellishprop (defaults to false) (#7521)diffglyph toEuiIcon(#7520)newChatglyph toEuiIcon(#7524)Bug fixes
EuiSideNavnot correctly typing theitemsprop as required (#7521)CSS is not definedbug inEuiPageTemplatewhen rendering in some SSR environments, particularly Next.js v13 and up (#7525)EuiDataGridcomponent to clean up timer from side effect on unmount (#7534)Accessibility
EuiSideNavto render a fallback aria-label on mobile toggles if no heading or mobile title exists (#7521)CSS-in-JS conversions
EuiSideNavto Emotion; Removed the following Sass variables: (#7521)$euiSideNavEmphasizedBackgroundColor$euiSideNavRootTextcolor$euiSideNavBranchTextcolor$euiSideNavSelectedTextcolor$euiSideNavDisabledTextcoloreuiSideNavEmbellishSass mixin. Use the newEuiPageSidebarhasEmbellishprop instead (#7521)