[8.13] [dashboard] fix console error "Panel not found" when linking or unlinking panel to library (#178464) #178590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king panel to library (elastic#178464) closes elastic#178442 There is a timing issue in `getComponentFromEmbeddable`. 1. `EmbeddablePanel` calls `getComponentFromEmbeddable`. 2. First `getComponentFromEmbeddable` call starts async operation `await Promise.all([startServicesPromise, embeddablePromise])` 3. Props for `EmbeddablePanel` get updated because dashboard.panels changes. `EmbeddablePanel` calls `getComponentFromEmbeddable` a second time because `props.embeddable` changes. 4. Results of first `getComponentFromEmbeddable` async call return. At this point, panels has changed and no longer contains id of old embeddable, but `getComponentFromEmbeddable` tries to call `untilEmbeddableLoaded` even though panel no longer exists. PR resolves issue by 1. adding isMounted check after async action and returning null if component is no longer mounted after `startServicesPromise, embeddablePromise` promises return 2. Syncronizing `EmbeddablePanel` `useMemo` and `PresentationPanel` `useAsync` dependency chain to ensure they are consistent. --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 49d8083)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @nreese |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.13:Questions ?
Please refer to the Backport tool documentation