-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detection Engine] adds AI Assistant to rule create form #179091
[Security Solution][Detection Engine] adds AI Assistant to rule create form #179091
Conversation
@vitaliidm Some videos here do not open, could you check please? |
@approksiu do you see any error? can you attach a screen recording with failure? I suspect it might be because github authentication token expired. It happens when page is opened for a long time. It works for me even from incognito tab, when I am not log in as myself. |
I get this error for ESQL case2 and Issues videos, refresh did not help: |
probably something related to browser/OS that could not play that video format. I'll share internal link to this video |
@vitaliidm What happens if the user clicks on the Ask assistant button before any query is inputted? |
I think we should hide it unless there is an actual warning/error on the query. The user has the option of AI assistant in the top nav/breadcrumb bar to open it separately. We can look at how to use AI more contextually in the whole form at a later date. |
We have also just rebranded the "Ask AI" button which can be seen here: |
This gives a more detail on how the ui should look. I hope it helps let me know if you need any more info. |
…aliidm/kibana into de_on_week/esql-ai-assistant
…aliidm/kibana into de_on_week/esql-ai-assistant
/** | ||
* Enables AI assistant on rule creation form when query has error | ||
*/ | ||
AIAssistantOnRuleCreationFormEnabled: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disable before merge. Needed for CI deployment to be testable
…aliidm/kibana into de_on_week/esql-ai-assistant
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @vitaliidm |
Summary
open_assistant_on_rule_query_error
AIAssistantOnRuleCreationFormEnabled
feature flagDesign
Design
Demo
new.UX.mov
Old Demoes
Note: old demo videos use old UI design, and assistant is shown even for valid queries.
list of videos
ES|QL Case 1
Simple ES|QL query validation error solving
There 2 problems in query highlighted by validation.
First, missing metadata operator
Second, operator
=
instead of==
By feeding query twice in Ai Assistant, I was able to get working solution
Screen.Recording.2024-03-20.at.16.15.02.mov
ES|QL Case 2
Fixes missing _id field, when metadata operator is present
4k.Screen.Recording.2024-03-21.at.16.08.21.mov
EQL Case 1
fixes EQL typo
Screen.Recording.2024-03-21.at.16.33.26.mov
Issues
Results might not be always consistent and for more complex queries they might not correct
Screen.Recording.2024-03-21.at.16.57.00.mov