Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metric threshold] Fix bug in loading the metric threshold alert details page #179219

Conversation

maryam-saeidi
Copy link
Member

Similar #175922

Summary

Fix the metric threshold alert details page by removing unnecessary dependencies.

Note
This page is disabled behind this feature flag: xpack.observability.unsafe.alertDetails.metrics.enabled

Before After
image image

@maryam-saeidi maryam-saeidi requested a review from a team as a code owner March 22, 2024 08:15
@maryam-saeidi maryam-saeidi added the release_note:skip Skip the PR/issue when compiling release notes label Mar 22, 2024
@maryam-saeidi maryam-saeidi self-assigned this Mar 22, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience Feature:Alert Details Page Observability ux management team labels Mar 22, 2024
@maryam-saeidi maryam-saeidi enabled auto-merge (squash) March 22, 2024 10:02
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.4MB 1.4MB -2.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit 59386ba into elastic:main Mar 22, 2024
25 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 22, 2024
@maryam-saeidi maryam-saeidi deleted the fix-bug-in-metric-threshold-details-page branch March 22, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Alert Details Page Observability ux management team release_note:skip Skip the PR/issue when compiling release notes v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants