-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Entity Analytics] Green execution of Cypress tests on MKI #179249
Conversation
/ci |
# Conflicts: # x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/dashboards/entity_analytics.cy.ts
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for doing this! If I have time I can take a look at the linked issue.
I'll just also tag @machadoum here as I believe he is more knowledgeable on that.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
In this PR we are introducing several changes to make sure we have a green execution of Cypress tests on MKI environments.
entity_analytics.cy.ts
between different spec filesinstallRiskScoreModule
methodSplit
entity_analytics.cy.ts
between different spec filesThe original spec file has a big execution time, what makes from time to time in MKI environment to perform a log off.
To try to avoid that, we have splited the spec file in 3 new ones inside the
entity_analytics
folder.Skipped managed data section test on MKI
It has been skipped just on MKI (the test will be executed in PRs for both serverless and ESS) since I don't know how to fix it. A ticket has been created to track it. It is now responsability of the team to investigate what is happening (I can give support with that).
Refactor of
installRiskScoreModule
methodThat method is returning a
401
on MKI, to fix it, we refactored to userootRequest
instead since it uses the basic API authentication by default.