Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Entity Analytics] Green execution of Cypress tests on MKI #179249

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Mar 22, 2024

Summary

In this PR we are introducing several changes to make sure we have a green execution of Cypress tests on MKI environments.

  • Split entity_analytics.cy.ts between different spec files
  • Skipped managed data section test on MKI
  • Refactor of installRiskScoreModule method

Split entity_analytics.cy.ts between different spec files

The original spec file has a big execution time, what makes from time to time in MKI environment to perform a log off.

To try to avoid that, we have splited the spec file in 3 new ones inside the entity_analytics folder.

  • anomalies.cy.ts
  • legacy_risk_score.cy.ts
  • new_risk_score.cy.ts

Skipped managed data section test on MKI

It has been skipped just on MKI (the test will be executed in PRs for both serverless and ESS) since I don't know how to fix it. A ticket has been created to track it. It is now responsability of the team to investigate what is happening (I can give support with that).

Refactor of installRiskScoreModule method

That method is returning a 401 on MKI, to fix it, we refactored to use rootRequest instead since it uses the basic API authentication by default.

@MadameSheema
Copy link
Member Author

/ci

# Conflicts:
#	x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/dashboards/entity_analytics.cy.ts
@MadameSheema MadameSheema changed the title splits tests [Security Solution][Entity Analytics] Green execution of Cypress tests on MKI Mar 25, 2024
@MadameSheema MadameSheema self-assigned this Mar 25, 2024
@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team v8.14.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Mar 25, 2024
@MadameSheema MadameSheema marked this pull request as ready for review March 25, 2024 10:45
@MadameSheema MadameSheema requested a review from a team as a code owner March 25, 2024 10:45
@MadameSheema MadameSheema requested a review from tiansivive March 25, 2024 10:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 🚀

Copy link
Contributor

@tiansivive tiansivive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for doing this! If I have time I can take a look at the linked issue.

I'll just also tag @machadoum here as I believe he is more knowledgeable on that.

@MadameSheema MadameSheema enabled auto-merge (squash) March 25, 2024 11:20
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 65bd8b0 into elastic:main Mar 25, 2024
35 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 25, 2024
@MadameSheema MadameSheema deleted the entity-analytics-mki branch June 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants